Rewrite of Connectivity01 (UDP connectivity)#1097
Merged
Merged
Conversation
This was referenced Sep 14, 2022
5dfd796 to
e9f4bc6
Compare
tgreenx
requested changes
Sep 15, 2022
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just a few comments.
Contributor
Author
|
@tgreenx, please re-review. |
Closed
tgreenx
reviewed
Sep 22, 2022
tgreenx
left a comment
Contributor
There was a problem hiding this comment.
Ready to approve after this last change.
Contributor
Author
|
Removed "A message will be outputted reporting that the transport protocol has been skipped." See #1098 (review) |
Contributor
Author
|
@tgreenx, added text to "objective" that message is outputted if IPv4/6 is disabled. |
tgreenx
previously approved these changes
Sep 22, 2022
ghost
reviewed
Sep 26, 2022
ghost
left a comment
There was a problem hiding this comment.
beside a small comment this is fine to me
ghost
previously approved these changes
Sep 26, 2022
ghost
approved these changes
Sep 28, 2022
tgreenx
approved these changes
Oct 3, 2022
Contributor
Author
|
Implemented by zonemaster/zonemaster-engine#1143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR is a complete rewrite of the test case. The main body of the the specification is copied from current Basic04, but TCP related parts have been removed. The plan is to remove Basic04 and let this test case be the only test case the completely reports errors of reaching the name servers over UDP.
Connectivity over TCP is covered by Connectivity02, that is updated by #1098.
Updates of references and removal of Basic04 is found in #1099.
Due to lack better alternative, the reporting, on NOTICE level, that IPv4 or IPv6 has been disabled, when applicable, has been included in this test case.
How to test this PR
This documentation only. Testing is done by reviewing and manual running the test case.