Skip to content

Rewrite of Connectivity02 (TCP connectivity)#1098

Merged
matsduf merged 5 commits into
zonemaster:developfrom
matsduf:update-connectivity02
Oct 7, 2022
Merged

Rewrite of Connectivity02 (TCP connectivity)#1098
matsduf merged 5 commits into
zonemaster:developfrom
matsduf:update-connectivity02

Conversation

@matsduf

@matsduf matsduf commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Purpose

This PR is a complete rewrite of the test case. The main body of the the specification is copied from the rewritten Connectivity01 (#1097).

How to test this PR

This documentation only. Testing is done by reviewing and manual running the test case.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Sep 14, 2022
@matsduf matsduf added this to the v2022.2 milestone Sep 14, 2022
@matsduf matsduf requested review from a user, mattias-p and tgreenx September 14, 2022 13:32

@tgreenx tgreenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this a pretty much a copy paste of #1097 most comments apply here also.
Most importantly this specification is missing message tags for disabled IPvX support.

Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md
@matsduf matsduf requested a review from tgreenx September 16, 2022 08:32
@matsduf

matsduf commented Sep 20, 2022

Copy link
Copy Markdown
Contributor Author

@tgreenx, please re-review.

@matsduf matsduf mentioned this pull request Sep 20, 2022
Comment thread docs/specifications/tests/Connectivity-TP/connectivity02.md Outdated
@matsduf matsduf requested a review from tgreenx September 22, 2022 13:32
tgreenx
tgreenx previously approved these changes Sep 22, 2022
ghost
ghost previously approved these changes Sep 26, 2022
Comment on lines +26 to +27
This Test Case will verify if the name servers in the delegation of and zone of
*Child Zone* are reachable over TCP.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be updated in the same manner as in b0210f8 (from #1097)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@matsduf matsduf dismissed stale reviews from ghost and tgreenx via 51e7163 September 28, 2022 15:20
@matsduf matsduf requested review from a user and tgreenx September 28, 2022 15:20
@matsduf

matsduf commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

@tgreenx, please re-review.

@matsduf matsduf merged commit 5a3c7b2 into zonemaster:develop Oct 7, 2022
@matsduf matsduf deleted the update-connectivity02 branch October 7, 2022 14:37
@matsduf

matsduf commented Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

Implemented in zonemaster/zonemaster-engine#1143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants