Skip to content

Replace basic04 with connectivity01#1099

Merged
matsduf merged 4 commits into
zonemaster:developfrom
matsduf:replace-basic04-with-connectivity01
Nov 3, 2022
Merged

Replace basic04 with connectivity01#1099
matsduf merged 4 commits into
zonemaster:developfrom
matsduf:replace-basic04-with-connectivity01

Conversation

@matsduf

@matsduf matsduf commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Purpose

This PR should be merged when #1097 has been merged.

This PR replaces all references to Basic04 with references to Connectivity01, and removes Basic04.

The test case template is also updated.

How to test this PR

Testing is done through review.

@matsduf matsduf added the A-TestCase Area: Test case specification or implementation of test case label Sep 14, 2022
@matsduf matsduf added this to the v2022.2 milestone Sep 14, 2022
@matsduf matsduf requested review from a user, mattias-p and tgreenx September 14, 2022 15:52

@tgreenx tgreenx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omitting TestMessages.md (updated by script with each release), I can see four places with references to Basic04 that were missed: README.md, ImplementedTestCases.md, MessageTagSpecification.md and IssueLabels.md.

Comment thread docs/specifications/tests/DNSSEC-TP/dnssec11.md Outdated
Comment thread docs/specifications/tests/DNSSEC-TP/dnssec09.md Outdated
Comment thread docs/specifications/tests/DNSSEC-TP/dnssec08.md Outdated
@matsduf

matsduf commented Sep 15, 2022

Copy link
Copy Markdown
Contributor Author

Omitting TestMessages.md (updated by script with each release), I can see four places with references to Basic04 that were missed: README.md, ImplementedTestCases.md, MessageTagSpecification.md and IssueLabels.md.

I am aware of those and have decided not to include them.

README.md -- Updated by script at release time. See https://github.com/zonemaster/zonemaster/blob/master/docs/specifications/tests/README.md?plain=1#L70

ImplementedTestCases.md -- Updated by script at release time. See https://github.com/zonemaster/zonemaster/blob/master/docs/specifications/tests/ImplementedTestCases.md?plain=1#L1

MessageTagSpecification.md -- Just an example, not a reference. Can be updated when the file is updated for other reasons.

IssueLabels.md -- Not a direct reference. Relevant to be updated, but in a separate PR when we do more updates to the file.

@matsduf matsduf requested a review from tgreenx September 16, 2022 07:14
@matsduf matsduf mentioned this pull request Sep 20, 2022
@matsduf

matsduf commented Nov 3, 2022

Copy link
Copy Markdown
Contributor Author

Implemented in zonemaster/zonemaster-engine#1143

@matsduf matsduf deleted the replace-basic04-with-connectivity01 branch November 3, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-TestCase Area: Test case specification or implementation of test case

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants