Skip to content

Update s390x actions runner#1981

Merged
Dead2 merged 1 commit intodevelopfrom
s390x_ci
Oct 10, 2025
Merged

Update s390x actions runner#1981
Dead2 merged 1 commit intodevelopfrom
s390x_ci

Conversation

@Dead2
Copy link
Copy Markdown
Member

@Dead2 Dead2 commented Oct 10, 2025

Update s390x actions runner.

  • Update to EL10
  • Update URL to s390x runner patch

This also fixes the missing node24 required by #1960

Summary by CodeRabbit

  • New Features

    • None
  • Bug Fixes

    • None
  • Chores

    • Updated CI workflows to target EL10 for S390X variants, including display names and coverage identifiers.
    • Renamed configure workflow labels from EL9 to EL10 for relevant jobs.
  • Build

    • Rebased self-hosted runner image to AlmaLinux 10.
    • Updated external patch source URL for runner setup.
  • Refactor

    • Removed obsolete clang RPM workaround from the self-hosted builder script.

- Update to EL10
- Update URL to s390x runner patch
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 10, 2025

Walkthrough

Raised EL target from EL9 to EL10 in multiple S390X GitHub Actions workflows, updated codecov identifiers accordingly, removed a Clang RPM workaround from the s390 self-hosted builder script, and switched the s390 actions-runner Docker base image to AlmaLinux 10 with an updated patch URL.

Changes

Cohort / File(s) Summary
GitHub Actions workflows: EL9→EL10 label updates
.github/workflows/cmake.yml, .github/workflows/configure.yml
Renamed S390X DFLTCC-related matrix/job display names and codecov target strings from EL9 to EL10; no logic/toolchain matrix changes beyond labels/identifiers.
s390 self-hosted builder script cleanup
arch/s390/self-hosted-builder/actions-runner-rebuild.sh
Removed creation/use/cleanup of temporary clang RPM directory and associated workaround steps; rest of rebuild flow unchanged.
s390 actions-runner container base update
arch/s390/self-hosted-builder/actions-runner.Dockerfile
Updated base image from almalinux:9 to almalinux:10 and changed runner patch URL from anup-kodlekere/gaplib to ppc64le/gaplib.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested labels

cleanup

Suggested reviewers

  • iii-i
  • nmoinvaz

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely summarizes the main change to the pull request by indicating an update to the s390x GitHub Actions runner configuration, which aligns with the actual modifications of upgrading from EL9 to EL10 and adjusting the runner patch URL.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch s390x_ci

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a9ef3eb and 634b9c6.

📒 Files selected for processing (4)
  • .github/workflows/cmake.yml (3 hunks)
  • .github/workflows/configure.yml (2 hunks)
  • arch/s390/self-hosted-builder/actions-runner-rebuild.sh (0 hunks)
  • arch/s390/self-hosted-builder/actions-runner.Dockerfile (2 hunks)
💤 Files with no reviewable changes (1)
  • arch/s390/self-hosted-builder/actions-runner-rebuild.sh
🔇 Additional comments (1)
arch/s390/self-hosted-builder/actions-runner.Dockerfile (1)

3-13: Confirm dotnet-sdk availability on AlmaLinux 10.

AlmaLinux 10 is very new and it’s unclear that dotnet-sdk-8.0 is already published in its repos. If the package is missing, the image build will fail. Please double-check the package exists (and whether any extra repo enablement is required) before merging.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.92%. Comparing base (a9ef3eb) to head (634b9c6).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1981       +/-   ##
============================================
+ Coverage    39.28%   80.92%   +41.64%     
============================================
  Files           73      161       +88     
  Lines         7904    13741     +5837     
  Branches      1280     3121     +1841     
============================================
+ Hits          3105    11120     +8015     
+ Misses        4575     1585     -2990     
- Partials       224     1036      +812     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Dead2 Dead2 merged commit 4fdd2e5 into develop Oct 10, 2025
304 checks passed
@Dead2 Dead2 mentioned this pull request Nov 5, 2025
@Dead2 Dead2 deleted the s390x_ci branch November 29, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants