Merged
Conversation
Contributor
WalkthroughThe updates modify the s390 self-hosted builder's actions-runner scripts and Dockerfile. Changes include improved handling of token expiration, a revised method for selecting the latest GitHub Actions runner tag, suppressed whitespace warnings during patching, removal of a custom Clang workaround, and elimination of a volume mount in the rebuild script. Changes
Sequence Diagram(s)sequenceDiagram
participant Script as actions-runner script
participant TokenFile as Token File
participant GitHub as GitHub API
Script->>TokenFile: Read token expiration (.expires_at)
alt Expiration missing or invalid
Script->>GitHub: Request new registration token (curl -sS)
GitHub-->>Script: Return new token with expiration
else Expiration valid and not expired
Script->>Script: Continue with existing token
end
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1929 +/- ##
===========================================
- Coverage 81.78% 81.65% -0.13%
===========================================
Files 147 150 +3
Lines 13319 13619 +300
Branches 2954 3052 +98
===========================================
+ Hits 10893 11121 +228
- Misses 1517 1536 +19
- Partials 909 962 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed 3 problems, removed clang workaround now that clang packages have been updated, and made some improvements to robustness and logging.
Hopefully it keeps working now 😄
Summary by CodeRabbit
Bug Fixes
Refactor
Chores