fix the url of the s390x actions worker patch#1882
Conversation
WalkthroughThe pull request updates the Dockerfile for the s390 self-hosted builder by changing the URL used to download a patch file. The original URL fetching a patch from a specific directory has been replaced with a URL pointing to Changes
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1882 +/- ##
===========================================
+ Coverage 82.37% 82.65% +0.28%
===========================================
Files 141 138 -3
Lines 12556 12373 -183
Branches 2894 2811 -83
===========================================
- Hits 10343 10227 -116
+ Misses 1237 1206 -31
+ Partials 976 940 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Name change is a good fix, but I am not so sure about locking it to a commit. It was locked previously and it masked a problem for a long time. If we could lock actions runner to a specific version, then this could perhaps have been useful, but unfortunately it keeps changing and the updated runner is required to be implemented within a couple weeks (or less if they deem a change important) to keep the runner activated with github actions. Also, making a PR in zlib-ng every time gaplib changes their patch because the runner has introduced an incompatible change is not very useful to us. To ensure that we actually detect breaking changes (like with the recent filename change), the gaplib docker is rebuilt by cron every week, so hopefully we detect the problem sooner than we did previously. This way we only notice when something that cannot be automatically resolved breaks. |
gaplib changed their patch name scheme with 1a5e012.
3f6e042 to
125e62f
Compare
gaplib changed their patch names. This fixes the path and pins the patch to a specific git hash instead of the main branch.
Summary by CodeRabbit