Calculate Radio Horizon In Line Of Sight Feature #220
Conversation
Show the connector frequency right next to the Frequency label, display the derived k value, and keep the info dialog tied to the exact
Show the connector frequency right next to the Frequency label, display the derived k value, and keep the info dialog tied to the exact
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 677b25908a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review if you have access |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec14870aed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78f1a7b28e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review but know that frequency doesnt automaticaly change when on los screen |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2585c0992
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex rip it apart |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea2f35ec2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@just-stuff-tm if you have a chance can you throw a few screen shots in here for us plebs :D |
|
|
|
|
|
do not merge noticing an overflow issue |
|
also removing the 0.15 calculation as that's not needed for true horizon calculation |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ddc87f3a27
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6065059241
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
|
Pr merged with #232 |
This PR introduces the curvature-of-earth effect on radio waves inside the Line-of-Sight feature:
k=ratio inline, and opens a localized info dialog that explains the exact0.15 × (frequency − baselineFreq) / baselineFreqadjustment from the 915 MHz / k=4/3 baseline so the yellow radio horizon cap is tied to the actual band being analyzed.LineOfSightService.analyzePath/computeFromElevationscarry the reported frequency and computedkFactor, expose those values in the result, and feed them to the painter, legend, and tooltip so the curved profile consistently reflects the operational frequency.app_*.arb, then regeneratedapp_localizations*.dart, giving every supported locale translated copy for the new UI text.Tests:
dart format lib/screens/line_of_sight_map_screen.dart,flutter gen-l10n,flutter analyze(still only the pre-existingonReorderdeprecation inlib/screens/channels_screen.dart:291:27).