Pr combined #228 #220 #219 #201#232
Merged
Merged
Conversation
…om sheet closes Root cause: edit/delete dialogs were opened from the sheet context after Navigator.pop, so context.mounted was false and follow-up actions never ran. Also keeps async await/error handling for channel edit/delete so failures surface to users instead of silently dropping.
…yping and translations
This reverts commit 0f2d18d.
Show the connector frequency right next to the Frequency label, display the derived k value, and keep the info dialog tied to the exact
Show the connector frequency right next to the Frequency label, display the derived k value, and keep the info dialog tied to the exact
…tions' into combined-prs
Contributor
Author
Owner
|
@codex review |
This was referenced Feb 24, 2026
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine PRs #228, #220, #219, #201
Summary
context.read<MeshCoreConnector>()so the new screen no longer tries to listen to providers/localizations before the widget tree is ready.Testing
dart format .flutter analyze(still reports the longstandingReorderableListView.onReorderdeprecation inlib/screens/channels_screen.dart).