fix: support all content types in local server endpoints#153
Merged
zivl merged 2 commits intozivl:masterfrom Jan 2, 2023
rchl:fix/parse-all
Merged
fix: support all content types in local server endpoints#153zivl merged 2 commits intozivl:masterfrom rchl:fix/parse-all
zivl merged 2 commits intozivl:masterfrom
rchl:fix/parse-all
Conversation
zivl
added a commit
that referenced
this pull request
Jan 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #152 so should be handled after the other one. The diff will become much smaller then.
This change removes all content-type restrictions for the bodyParser middleware. The reason for that is that I found a case that is not properly handled. For Node-side events whose size is over the threshold Sentry will send those gzip-compressed but without content-type. That meant that those were not processed by
bodyParserand we entered the block that does manual body processing but that failed due to not handlinggzipedcontent.To solve that, removed custom body parsing code and enabled
bodyParserfor all content types.