fix: local server not capturing error events from the browser#152
Merged
zivl merged 1 commit intozivl:masterfrom Jan 3, 2023
rchl:fix/browser-v7
Merged
fix: local server not capturing error events from the browser#152zivl merged 1 commit intozivl:masterfrom rchl:fix/browser-v7
zivl merged 1 commit intozivl:masterfrom
rchl:fix/browser-v7
Conversation
Owner
zivl
approved these changes
Jan 2, 2023
Contributor
Author
Contributor
Author
Owner
|
@rchl yeah you're right. |
Contributor
Author
|
I can do it at any time but then you'd need to click revert on #153 first. It should create a revert commit and then you should be able to merge this one first. |
Owner
|
on it #160 |
Contributor
Author
|
Feel free to merge this one first now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for capturing error events sent from the Browser (as opposed to from the Node) was missing. When browser makes a POST request to the server, the
transfer-encoding: chunkedencoding is not used and the block that handled that case was missing error parsing and adding toreports().While at it, I've consolidated 3 places that did the request body parsing and event processing into single exported function. This should hopefully ensure that no one forgets about handling one of the places in the future as there will be only one place to change. (Let me know if this new function should live somewhere else).
I've looked into adding test for this case but that would require a setup for testing using real browser and that would require quite a bit of work to set up and those tests would significantly slow down the testsuite.