chore: Remove unused internal feature flag _all-features#612
chore: Remove unused internal feature flag _all-features#612Pr0methean merged 1 commit intomasterfrom
_all-features#612Conversation
Summary of ChangesHello @Pr0methean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a minor cleanup task by removing an unused internal feature flag from the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
This PR correctly removes the unused _all-features internal feature flag from Cargo.toml. The change is clean and follows the Conventional Commits format. The removal doesn't impact any other features or functionality, making this a safe cleanup change that addresses part of issue #605.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Code Review
This pull request removes the unused internal feature flag _all-features from Cargo.toml. This is a good cleanup, as the feature flag does not appear to be used anywhere in the provided code. The change is correct and improves the maintainability of the project. I have no further comments.
…ds public (#616) * fix #612 * fix: document more extra field * better fix * feat: add a usage test * aslways use defined constants * Update src/write.rs Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Signed-off-by: n4n5 <git@n4n5.dev> * Update Cargo.toml Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com> Signed-off-by: n4n5 <git@n4n5.dev> * fix * Fix `test_extra_field_access`: asserting both decimal and hex values --------- Signed-off-by: n4n5 <git@n4n5.dev> Co-authored-by: Chris Hennick <4961925+Pr0methean@users.noreply.github.com>
Partial fix for #605.