Skip to content

Checking the crate #605

@Its-Just-Nans

Description

@Its-Just-Nans

I was checking the crate

  1. it looks like we can get rid of generic-array - checked with cargo shear

  2. Features combinations

    I was testing multiples features with

    cargo hack test --feature-powerset --all-targets
    # or better with
    cargo hack test --feature-powerset --all-targets --exclude-features _bzip2_any,_arbitrary,_deflate-any,_all-features

    And it seems that

    cargo test --all-targets --no-default-features

    Is failing (for the benchmarks) because i think we need to:

    • the std feature for getrandom devpendencies.
      or
    • change the errors of getrandom since without std it doesn't implement std::io::Error
  3. Private features

    This command is failing

    cargo test --all-targets --no-default-features --features _bzip2_any

    this is normal since it's "private" but maybe we should remove the "private" featureS no ?

  4. _all-features feature seems useless

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions