Move modal to field renderer#40
Merged
zero-24 merged 4 commits intozero-24:confirmConsentfrom Nov 26, 2018
SharkyKZ:patch-1
Merged
Move modal to field renderer#40zero-24 merged 4 commits intozero-24:confirmConsentfrom SharkyKZ:patch-1
zero-24 merged 4 commits intozero-24:confirmConsentfrom
SharkyKZ:patch-1
Conversation
mbabker
reviewed
Nov 26, 2018
Owner
|
Merged |
zero-24
added a commit
that referenced
this pull request
Dec 1, 2018
* move to it own field * move to it own field * fix since * $modalHTML * init html and drone * drone ... * Move modal to field renderer (#40) * Move modal to field renderer * Fix var type * Fix wrong variable * __DEPLOY_VERSION__
zero-24
pushed a commit
that referenced
this pull request
Aug 15, 2019
zero-24
pushed a commit
that referenced
this pull request
Mar 23, 2025
…44675) * com_contenthistory-admin-test: Add Cypress test for Content History * cs * wait for #40 * single-quotes * open history content in modal * actions-on-history-item * wait-pr-40 * remove-todo * joomla-cypress to version 1.3.0 * retry * delete-last * aftereach * undo --------- Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Moves modal to field renderer.
Misc cleanups.
Testing Instructions
Expected result
Actual result
Documentation Changes Required