This still outputs the modal when it shouldn't. There can be no echos in field class.

Well i have been told to move it to its own field -> done. If that is not the right solution please suggest the correct solution and i'm happy to apply it ;-)

And please also review the other fields that just output html code inside a field..

You don't echo the modal, assign the result of JHtml::_() to a variable (i.e. $html).

Then have your return concatenate the modal and the layout (i.e. return $html . $this->getRenderer($this->renderLabelLayout)->render(array_merge($data, $extraData));

This field uses modals in this way.

Patched.

Ok what is the plan here? Patch this in 3.9.1 or move both PRs to 3.9.2?

Well if someone would actually test this...

There's a styling issue with modal header. It's right-aligned because of label. Perhaps modal output should be added to renderField() instead.

@zero-24 see zero-24#40.

Merged thanks @SharkyKZ

I have tested this item ✅ successfully on 819b32a