Skip to content

skill_creator: Make window resizable and form scrollable#57754

Merged
danilo-leal merged 3 commits into
mainfrom
fast-fix-reduce-skill-body-height
May 27, 2026
Merged

skill_creator: Make window resizable and form scrollable#57754
danilo-leal merged 3 commits into
mainfrom
fast-fix-reduce-skill-body-height

Conversation

@MartinYe1234

@MartinYe1234 MartinYe1234 commented May 26, 2026

Copy link
Copy Markdown
Contributor

The Skill Creator window previously couldn't be resized — its minimum size was set to the same dimensions as its initial size, so users couldn't make it smaller or shorter. Its contents also didn't scroll, so on smaller windows the Skill Content editor would be squeezed below its usable size.

This change:

  • Lowers the window's minimum size to 500×420 so it can be resized in both directions.
  • Wraps the form body in a scrollable container with a vertical scrollbar.
  • Replaces flex_1 + min_h_0 on the form fields and Skill Content wrapper with flex_grow + flex_shrink_0. Combined with the existing min_h(160) on the body editor, this means:
    • When there's extra vertical space, the Skill Content editor grows to fill it.
    • When the window is short, the form keeps its content at natural size and the outer container scrolls instead of crushing the editor.

Closes AI-315
Release Notes:

  • Made the Skill Creator window resizable and its contents scrollable when the window is smaller than the form.

@MartinYe1234 MartinYe1234 self-assigned this May 26, 2026
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 26, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 26, 2026
@MartinYe1234 MartinYe1234 marked this pull request as ready for review May 26, 2026 18:27
@danilo-leal danilo-leal added this pull request to the merge queue May 27, 2026
Merged via the queue into main with commit a718a2b May 27, 2026
32 checks passed
@danilo-leal danilo-leal deleted the fast-fix-reduce-skill-body-height branch May 27, 2026 13:30
@danilo-leal

Copy link
Copy Markdown
Member

/cherry-pick preview

@zed-zippy

zed-zippy Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/26514836267

danilo-leal pushed a commit that referenced this pull request May 27, 2026
The Skill Creator window previously couldn't be resized — its minimum
size was set to the same dimensions as its initial size, so users
couldn't make it smaller or shorter. Its contents also didn't scroll, so
on smaller windows the Skill Content editor would be squeezed below its
usable size.

This change:

- Lowers the window's minimum size to 500×420 so it can be resized in
both directions.
- Wraps the form body in a scrollable container with a vertical
scrollbar.
- Replaces `flex_1 + min_h_0` on the form fields and Skill Content
wrapper with `flex_grow + flex_shrink_0`. Combined with the existing
`min_h(160)` on the body editor, this means:
- When there's extra vertical space, the Skill Content editor grows to
fill it.
- When the window is short, the form keeps its content at natural size
and the outer container scrolls instead of crushing the editor.

Closes AI-315
Release Notes:

- Made the Skill Creator window resizable and its contents scrollable
when the window is smaller than the form.
MartinYe1234 added a commit that referenced this pull request May 27, 2026
…erry-pick to preview) (#57839)

Cherry-pick of #57754 to preview

----
The Skill Creator window previously couldn't be resized — its minimum
size was set to the same dimensions as its initial size, so users
couldn't make it smaller or shorter. Its contents also didn't scroll, so
on smaller windows the Skill Content editor would be squeezed below its
usable size.

This change:

- Lowers the window's minimum size to 500×420 so it can be resized in
both directions.
- Wraps the form body in a scrollable container with a vertical
scrollbar.
- Replaces `flex_1 + min_h_0` on the form fields and Skill Content
wrapper with `flex_grow + flex_shrink_0`. Combined with the existing
`min_h(160)` on the body editor, this means:
- When there's extra vertical space, the Skill Content editor grows to
fill it.
- When the window is short, the form keeps its content at natural size
and the outer container scrolls instead of crushing the editor.

Closes AI-315
Release Notes:

- Made the Skill Creator window resizable and its contents scrollable
when the window is smaller than the form.

Co-authored-by: MartinYe1234 <52641447+MartinYe1234@users.noreply.github.com>
TomPlanche pushed a commit to TomPlanche/zed that referenced this pull request Jun 2, 2026
…ies#57754)

The Skill Creator window previously couldn't be resized — its minimum
size was set to the same dimensions as its initial size, so users
couldn't make it smaller or shorter. Its contents also didn't scroll, so
on smaller windows the Skill Content editor would be squeezed below its
usable size.

This change:

- Lowers the window's minimum size to 500×420 so it can be resized in
both directions.
- Wraps the form body in a scrollable container with a vertical
scrollbar.
- Replaces `flex_1 + min_h_0` on the form fields and Skill Content
wrapper with `flex_grow + flex_shrink_0`. Combined with the existing
`min_h(160)` on the body editor, this means:
- When there's extra vertical space, the Skill Content editor grows to
fill it.
- When the window is short, the form keeps its content at natural size
and the outer container scrolls instead of crushing the editor.

Closes AI-315
Release Notes:

- Made the Skill Creator window resizable and its contents scrollable
when the window is smaller than the form.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants