Skip to content

skill_creator: Make window resizable and form scrollable (#57754) (cherry-pick to preview)#57839

Merged
MartinYe1234 merged 1 commit into
v1.4.xfrom
cherry-pick-v1.4.x-a718a2bd
May 27, 2026
Merged

skill_creator: Make window resizable and form scrollable (#57754) (cherry-pick to preview)#57839
MartinYe1234 merged 1 commit into
v1.4.xfrom
cherry-pick-v1.4.x-a718a2bd

Conversation

@danilo-leal

Copy link
Copy Markdown
Member

Cherry-pick of #57754 to preview


The Skill Creator window previously couldn't be resized — its minimum
size was set to the same dimensions as its initial size, so users
couldn't make it smaller or shorter. Its contents also didn't scroll, so
on smaller windows the Skill Content editor would be squeezed below its
usable size.

This change:

  • Lowers the window's minimum size to 500×420 so it can be resized in
    both directions.
  • Wraps the form body in a scrollable container with a vertical
    scrollbar.
  • Replaces flex_1 + min_h_0 on the form fields and Skill Content
    wrapper with flex_grow + flex_shrink_0. Combined with the existing
    min_h(160) on the body editor, this means:
  • When there's extra vertical space, the Skill Content editor grows to
    fill it.
  • When the window is short, the form keeps its content at natural size
    and the outer container scrolls instead of crushing the editor.

Closes AI-315
Release Notes:

  • Made the Skill Creator window resizable and its contents scrollable
    when the window is smaller than the form.

The Skill Creator window previously couldn't be resized — its minimum
size was set to the same dimensions as its initial size, so users
couldn't make it smaller or shorter. Its contents also didn't scroll, so
on smaller windows the Skill Content editor would be squeezed below its
usable size.

This change:

- Lowers the window's minimum size to 500×420 so it can be resized in
both directions.
- Wraps the form body in a scrollable container with a vertical
scrollbar.
- Replaces `flex_1 + min_h_0` on the form fields and Skill Content
wrapper with `flex_grow + flex_shrink_0`. Combined with the existing
`min_h(160)` on the body editor, this means:
- When there's extra vertical space, the Skill Content editor grows to
fill it.
- When the window is short, the form keeps its content at natural size
and the outer container scrolls instead of crushing the editor.

Closes AI-315
Release Notes:

- Made the Skill Creator window resizable and its contents scrollable
when the window is smaller than the form.
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label May 27, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label May 27, 2026
@MartinYe1234 MartinYe1234 merged commit 824e687 into v1.4.x May 27, 2026
42 checks passed
@MartinYe1234 MartinYe1234 deleted the cherry-pick-v1.4.x-a718a2bd branch May 27, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants