lsp: Handle dynamic registration of textDocument/documentLink#57749
Merged
Conversation
SomeoneToIgnore
approved these changes
May 26, 2026
SomeoneToIgnore
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the catch!
`register_server_capabilities` / `unregister_server_capabilities` had no arm for `textDocument/documentLink`, so when a server saw our `documentLink.dynamicRegistration` capability and chose to register the provider dynamically, the registration silently fell into the `unhandled capability registration` warning. `document_link_provider` stayed `None`, `GetDocumentLinks::check_capabilities` returned false, and no `textDocument/documentLink` request was ever sent. Fixes up zed-industries#56011. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
…dustries#57749) `register_server_capabilities` / `unregister_server_capabilities` had no arm for `textDocument/documentLink`, so when a server saw our `documentLink.dynamicRegistration` capability and chose to register the provider dynamically, the registration silently fell into the `unhandled capability registration` warning. `document_link_provider` stayed `None`, `GetDocumentLinks::check_capabilities` returned false, and no `textDocument/documentLink` request was ever sent. Follow-up to zed-industries#56011 Release Notes: - N/A Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
register_server_capabilities/unregister_server_capabilitieshad no arm fortextDocument/documentLink, so when a server saw ourdocumentLink.dynamicRegistrationcapability and chose to register the provider dynamically, the registration silently fell into theunhandled capability registrationwarning.document_link_providerstayedNone,GetDocumentLinks::check_capabilitiesreturned false, and notextDocument/documentLinkrequest was ever sent.Follow-up to #56011
Release Notes: