Support LSP document links#56011
Merged
Merged
Conversation
9d2ae70 to
a50b793
Compare
e660f37 to
96ce1de
Compare
# Conflicts: # crates/editor/src/editor.rs
96ce1de to
9e5a33a
Compare
Veykril
approved these changes
May 26, 2026
Contributor
|
Dynamic registration seems to need to be fixed. Opened a follow up PR: #57749 |
aviatesk
added a commit
to aviatesk/zed
that referenced
this pull request
May 26, 2026
`register_server_capabilities` / `unregister_server_capabilities` had no arm for `textDocument/documentLink`, so when a server saw our `documentLink.dynamicRegistration` capability and chose to register the provider dynamically, the registration silently fell into the `unhandled capability registration` warning. `document_link_provider` stayed `None`, `GetDocumentLinks::check_capabilities` returned false, and no `textDocument/documentLink` request was ever sent. Fixes up zed-industries#56011. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
12122J
pushed a commit
to 12122J/zed
that referenced
this pull request
May 26, 2026
…dustries#57749) `register_server_capabilities` / `unregister_server_capabilities` had no arm for `textDocument/documentLink`, so when a server saw our `documentLink.dynamicRegistration` capability and chose to register the provider dynamically, the registration silently fell into the `unhandled capability registration` warning. `document_link_provider` stayed `None`, `GetDocumentLinks::check_capabilities` returned false, and no `textDocument/documentLink` request was ever sent. Follow-up to zed-industries#56011 Release Notes: - N/A Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Contributor
|
One more follow-up I wonder about: should we render document link ranges as underlined by default, similar to how VS Code does? Right now, Would you be open to that as a follow-up? |
Contributor
Author
|
I'd ask a designer for that, myself is not very open to that as it adds more visual noise than needed. |
Contributor
|
Understood. I think the noise argument has a validity. Since I only mentioned it as a tentative suggestion, I will hold off on upstreaming this idea for now. |
jasonsmithio
pushed a commit
to paddleboarddev/paddleboard
that referenced
this pull request
May 31, 2026
`register_server_capabilities` / `unregister_server_capabilities` had no arm for `textDocument/documentLink`, so when a server saw our `documentLink.dynamicRegistration` capability and chose to register the provider dynamically, the registration silently fell into the `unhandled capability registration` warning. `document_link_provider` stayed `None`, `GetDocumentLinks::check_capabilities` returned false, and no `textDocument/documentLink` request was ever sent. Follow-up to zed-industries/zed#56011 Release Notes: - N/A Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
Closes zed-industries#33587 https://github.com/user-attachments/assets/bbaea8a9-402e-485b-800e-2f4486142956 Release Notes: - Supported LSP document links (enabled by default, use `"lsp_document_links": false` to turn it off)
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 2, 2026
…dustries#57749) `register_server_capabilities` / `unregister_server_capabilities` had no arm for `textDocument/documentLink`, so when a server saw our `documentLink.dynamicRegistration` capability and chose to register the provider dynamically, the registration silently fell into the `unhandled capability registration` warning. `document_link_provider` stayed `None`, `GetDocumentLinks::check_capabilities` returned false, and no `textDocument/documentLink` request was ever sent. Follow-up to zed-industries#56011 Release Notes: - N/A Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33587
LSP.document.links.mov
Release Notes:
"lsp_document_links": falseto turn it off)