Skip to content

Don't save buffers by default when running tasks#52976

Merged
SomeoneToIgnore merged 3 commits intozed-industries:mainfrom
injust:task-save-none
Apr 2, 2026
Merged

Don't save buffers by default when running tasks#52976
SomeoneToIgnore merged 3 commits intozed-industries:mainfrom
injust:task-save-none

Conversation

@injust
Copy link
Copy Markdown
Contributor

@injust injust commented Apr 2, 2026

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content is consistent with the UI/UX checklist
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Closes #52926
Follow-up to #48861
cc @SomeoneToIgnore

Release Notes:

  • Edited buffers are no longer saved by default before running a task, but you can still configure this using the "save" field in tasks.json.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 2, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Apr 2, 2026
@zed-codeowner-coordinator zed-codeowner-coordinator bot requested review from a team, MrSubidubi, SomeoneToIgnore, Veykril and kubkon and removed request for a team April 2, 2026 09:29
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore SomeoneToIgnore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, added a style fix from my stab at it.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Apr 2, 2026
@SomeoneToIgnore SomeoneToIgnore enabled auto-merge (squash) April 2, 2026 12:44
@SomeoneToIgnore SomeoneToIgnore merged commit a7248e8 into zed-industries:main Apr 2, 2026
30 checks passed
@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

/cherry-pick preview
/cherry-pick stable

github-actions bot pushed a commit that referenced this pull request Apr 2, 2026
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [ ] Performance impact has been considered and is acceptable

Closes #52926
Follow-up to #48861
cc @SomeoneToIgnore

Release Notes:

- Edited buffers are no longer saved by default before running a task,
but you can still configure this using the "save" field in `tasks.json`.

---------

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
github-actions bot pushed a commit that referenced this pull request Apr 2, 2026
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [ ] Performance impact has been considered and is acceptable

Closes #52926
Follow-up to #48861
cc @SomeoneToIgnore

Release Notes:

- Edited buffers are no longer saved by default before running a task,
but you can still configure this using the "save" field in `tasks.json`.

---------

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
@zed-zippy
Copy link
Copy Markdown
Contributor

zed-zippy bot commented Apr 2, 2026

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/23902016562

@zed-zippy
Copy link
Copy Markdown
Contributor

zed-zippy bot commented Apr 2, 2026

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/23902017957

@zed-zippy
Copy link
Copy Markdown
Contributor

zed-zippy bot commented Apr 2, 2026

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/23902015168

SomeoneToIgnore added a commit that referenced this pull request Apr 2, 2026
…k to preview) (#52990)

Cherry-pick of #52976 to preview

----
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX

checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [ ] Performance impact has been considered and is acceptable

Closes #52926
Follow-up to #48861
cc @SomeoneToIgnore

Release Notes:

- Edited buffers are no longer saved by default before running a task,
but you can still configure this using the "save" field in `tasks.json`.

---------

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

Co-authored-by: Justin Su <injustsu@gmail.com>
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
@SomeoneToIgnore
Copy link
Copy Markdown
Contributor

/cherry-pick stable

@zed-zippy
Copy link
Copy Markdown
Contributor

zed-zippy bot commented Apr 2, 2026

🍒💥 Cherry-pick did not succeed
https://github.com/zed-industries/zed/actions/runs/23902161231

SomeoneToIgnore added a commit that referenced this pull request Apr 2, 2026
Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [ ] Performance impact has been considered and is acceptable

Closes #52926
Follow-up to #48861
cc @SomeoneToIgnore

Release Notes:

- Edited buffers are no longer saved by default before running a task,
but you can still configure this using the "save" field in `tasks.json`.

---------

Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
@injust injust deleted the task-save-none branch April 2, 2026 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in tasks can't be used if you work with unsaved buffers

3 participants