Save edited buffers before running a task by abenea · Pull Request #48861 · zed-industries/zed

abenea · 2026-02-10T08:19:47Z

Save edited buffers before running a task

Introduces a new task field for configuring which buffers are saved. For now, this defaults to saving all buffers, but in the future we could have a global task template to configure this setting for dynamically created tasks.

Closes #10251.

Release Notes:

Edited buffers are now saved before running a task. This can be configured with the new "save" field in tasks.json.

cla-bot · 2026-02-10T08:19:51Z

We require contributors to sign our Contributor License Agreement, and we don't have @abenea on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

abenea · 2026-02-10T08:22:24Z

@cla-bot check

cla-bot · 2026-02-10T08:22:27Z

We require contributors to sign our Contributor License Agreement, and we don't have @abenea on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot · 2026-02-10T08:22:29Z

The cla-bot has been summoned, and re-checked this pull request!

abenea · 2026-02-10T08:24:32Z

@cla-bot check

cla-bot · 2026-02-10T08:24:36Z

The cla-bot has been summoned, and re-checked this pull request!

SomeoneToIgnore

Thank you, after a few tweaks this should be a nice way to add the functionality in general.

assets/settings/default.json

crates/workspace/src/tasks.rs

SomeoneToIgnore

Great to see entities not moved into tasks now, we're almost there.

To add to the settings discussion, let's add the "save the current file" when making the rest of the changes.
It makes sense to have the "save all" by default for now, and work on the "global template" to override global task defaults later.

SomeoneToIgnore

Great, thank you!

All that's left are style nits and one extra doc entry and we're good to merge.

assets/settings/initial_tasks.json

crates/project/tests/integration/debugger.rs

crates/workspace/src/tasks.rs

Introduces a new task field for configuring which buffers are saved. For now, this defaults to saving all buffers, but in the future we could have a global task template to configure this setting for dynamically created tasks. Needed for zed-industries#10251. Release Notes: - Edited buffers are now saved before running a task. This can be configured with the new "save" field in `tasks.json`.

SomeoneToIgnore

Thank you so much!

docs/src/tasks.md

Save edited buffers before running a task Introduces a new task field for configuring which buffers are saved. For now, this defaults to saving all buffers, but in the future we could have a global task template to configure this setting for dynamically created tasks. Needed for zed-industries#10251. Release Notes: - Edited buffers are now saved before running a task. This can be configured with the new "save" field in `tasks.json`. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

injust · 2026-04-01T19:41:48Z

I don't think saving all buffers is a reasonable default, see #52926.

SomeoneToIgnore · 2026-04-01T22:10:02Z

Indeed, seems that we cannot use the "save a single file" mode either and have to fall back to the "save nothing" mode until the global task template configuration is implemented?

injust · 2026-04-01T23:49:14Z

seems that we cannot use the "save a single file" mode either

This is what I observed when testing the Python tasks:

The play button appears in the gutter for all Python buffers, but the button only works in saved files (Play button appears in gutter for unsaved buffers, but is a no-op #52942). So "save a single file" works fine here.
If you run the "task: spawn" command, the Python tasks appear if the current file is a saved Python buffer. However, they also appear as a recently run task. I haven't tested this, but I assume if you run that task while an unsaved buffer is focused, then it will try to save that file?

So defaulting to "save the current file" is significantly less breaking of a change, but there is still an edge case.

SomeoneToIgnore · 2026-04-02T09:00:53Z

if you run that task while an unsaved buffer is focused, then it will try to save that file

Yes, well noted, so this implementation is not really ready to be the default in any of the saving options it seems.
It seems that we need more granularity when saving files, to allow us to limit saving to a certain worktree [and a certain buffer in it].

For now, let's keep the "nothing saved" default then, thank you.

injust · 2026-04-02T09:29:52Z

For now, let's keep the "nothing saved" default then, thank you.

I put up a quick PR for this, but I haven't built and tested because I don't have a local dev environment set up.

SomeoneToIgnore · 2026-04-02T12:45:35Z

Thank you, I've tested that on my machine and it works (had implemented the same fix essentially).

I've also tried to set up a branch with a forward fix where we skip non-worktree-related files, but got stuck at writing the test — maybe someone else later can take a stab at it.

@SomeoneToIgnore

Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #52926 Follow-up to #48861 cc @SomeoneToIgnore Release Notes: - Edited buffers are no longer saved by default before running a task, but you can still configure this using the "save" field in `tasks.json`. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

@SomeoneToIgnore

Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #52926 Follow-up to #48861 cc @SomeoneToIgnore Release Notes: - Edited buffers are no longer saved by default before running a task, but you can still configure this using the "save" field in `tasks.json`. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

@SomeoneToIgnore

Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #52926 Follow-up to #48861 cc @SomeoneToIgnore Release Notes: - Edited buffers are no longer saved by default before running a task, but you can still configure this using the "save" field in `tasks.json`. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

@SomeoneToIgnore

…k to preview) (#52990) Cherry-pick of #52976 to preview ---- Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #52926 Follow-up to #48861 cc @SomeoneToIgnore Release Notes: - Edited buffers are no longer saved by default before running a task, but you can still configure this using the "save" field in `tasks.json`. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: Justin Su <injustsu@gmail.com> Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

@SomeoneToIgnore

Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [ ] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [ ] Tests cover the new/changed behavior - [ ] Performance impact has been considered and is acceptable Closes #52926 Follow-up to #48861 cc @SomeoneToIgnore Release Notes: - Edited buffers are no longer saved by default before running a task, but you can still configure this using the "save" field in `tasks.json`. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com>

zed-community-bot bot added the first contribution the author's first pull request to Zed. NOTE: the label application is automated via github actions label Feb 10, 2026

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 10, 2026

abenea changed the title ~~Implement save_before_task_run setting (fixes #10251).~~ Implement save_before_task_run setting Feb 10, 2026

abenea force-pushed the push-yowqqywxulnr branch from f4513e4 to 0cd2519 Compare February 12, 2026 20:15

abenea marked this pull request as draft February 13, 2026 03:34

abenea force-pushed the push-yowqqywxulnr branch from 0cd2519 to d989cca Compare February 14, 2026 12:29

abenea marked this pull request as ready for review February 14, 2026 12:31

abenea mentioned this pull request Feb 21, 2026

Optionally save dirty buffers before running a task #10251

Closed

1 task

abenea force-pushed the push-yowqqywxulnr branch from d989cca to 5a912b7 Compare February 27, 2026 04:31

MrSubidubi assigned SomeoneToIgnore Mar 12, 2026

SomeoneToIgnore reviewed Mar 13, 2026

View reviewed changes

assets/settings/default.json Outdated Show resolved Hide resolved

crates/workspace/src/tasks.rs Outdated Show resolved Hide resolved

abenea force-pushed the push-yowqqywxulnr branch from 5a912b7 to 91f66bb Compare March 14, 2026 19:58

abenea requested a review from SomeoneToIgnore March 14, 2026 19:59

abenea force-pushed the push-yowqqywxulnr branch from 91f66bb to c333a61 Compare March 14, 2026 20:12

SomeoneToIgnore requested changes Mar 16, 2026

View reviewed changes

abenea force-pushed the push-yowqqywxulnr branch from c333a61 to ef428dc Compare March 17, 2026 19:10

abenea changed the title ~~Implement save_before_task_run setting~~ Save edited buffers before running a task Mar 17, 2026

abenea requested a review from SomeoneToIgnore March 17, 2026 19:15

SomeoneToIgnore reviewed Mar 17, 2026

View reviewed changes

abenea force-pushed the push-yowqqywxulnr branch from ef428dc to 5634a12 Compare March 18, 2026 21:05

abenea requested a review from SomeoneToIgnore March 18, 2026 21:14

SomeoneToIgnore approved these changes Mar 19, 2026

View reviewed changes

SomeoneToIgnore reviewed Mar 19, 2026

View reviewed changes

docs/src/tasks.md Outdated Show resolved Hide resolved

github-actions bot added the size/M label Mar 19, 2026

Tidy up

8daf2b3

SomeoneToIgnore force-pushed the push-yowqqywxulnr branch from 9a4dad2 to 8daf2b3 Compare March 19, 2026 08:31

SomeoneToIgnore enabled auto-merge (squash) March 19, 2026 08:31

github-actions bot added size/M and removed size/M labels Mar 19, 2026

SomeoneToIgnore merged commit 0698ecc into zed-industries:main Mar 19, 2026
31 checks passed

injust mentioned this pull request Apr 2, 2026

Don't save buffers by default when running tasks #52976

Merged

5 tasks

zed-zippy bot mentioned this pull request Apr 2, 2026

Don't save buffers by default when running tasks (#52976) (cherry-pick to preview) #52990

Merged

5 tasks

Uh oh!

Conversation

abenea commented Feb 10, 2026 • edited by SomeoneToIgnore Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cla-bot bot commented Feb 10, 2026

Uh oh!

abenea commented Feb 10, 2026

Uh oh!

cla-bot bot commented Feb 10, 2026

Uh oh!

cla-bot bot commented Feb 10, 2026

Uh oh!

abenea commented Feb 10, 2026

Uh oh!

cla-bot bot commented Feb 10, 2026

Uh oh!

SomeoneToIgnore left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SomeoneToIgnore left a comment

Choose a reason for hiding this comment

Uh oh!

SomeoneToIgnore left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SomeoneToIgnore left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

injust commented Apr 1, 2026

Uh oh!

SomeoneToIgnore commented Apr 1, 2026

Uh oh!

injust commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SomeoneToIgnore commented Apr 2, 2026

Uh oh!

injust commented Apr 2, 2026

Uh oh!

SomeoneToIgnore commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

abenea commented Feb 10, 2026 •

edited by SomeoneToIgnore

Loading

injust commented Apr 1, 2026 •

edited

Loading