acp: Fix stale ACP reasoning-effort options when model switch keeps same config IDs#50246
Merged
benbrandt merged 3 commits intozed-industries:mainfrom Feb 26, 2026
Merged
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @nikhil-pandey on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
We require contributors to sign our Contributor License Agreement, and we don't have @nikhil-pandey on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Contributor
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Member
|
/cherry-pick preview |
Member
|
/cherry-pick stable |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
…ame config IDs (#50246) ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
…ame config IDs (#50246) ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
zed-zippy bot
added a commit
that referenced
this pull request
Feb 26, 2026
…ame config IDs (#50246) (cherry-pick to preview) (#50251) Cherry-pick of #50246 to preview ---- ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: Nikhil Pandey <nikhil@nikhil.com.np> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
zed-zippy bot
added a commit
that referenced
this pull request
Feb 26, 2026
…ame config IDs (#50246) (cherry-pick to stable) (#50252) Cherry-pick of #50246 to stable ---- ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com> Co-authored-by: Nikhil Pandey <nikhil@nikhil.com.np> Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
rtfeldman
pushed a commit
that referenced
this pull request
Feb 27, 2026
…ame config IDs (#50246) ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
tahayvr
pushed a commit
to tahayvr/zed
that referenced
this pull request
Mar 4, 2026
…ame config IDs (zed-industries#50246) ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed.
For many model switches, the IDs stay the same (
mode,model,reasoning_effort) while the valid values forreasoning_effortchange by model. As a result, the picker could show stale values (for example, missingxhighongpt-5.3-codex, or showing extraxhighafter switching away).This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities.
Fix
Rebuild ACP config-option selectors on every
config_option_update, not only when config IDs change.This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged.
User Impact
Validation
cargo check -p agent_uiremains blocked by unrelated pre-existinglivekit-protocolcompile errors in this checkout.Files Changed
crates/agent_ui/src/acp/config_options.rsRelease Notes: