acp: Fix stale ACP reasoning-effort options when model switch keeps same config IDs (#50246) (cherry-pick to stable)#50252
Merged
zed-zippy[bot] merged 1 commit intov0.225.xfrom Feb 26, 2026
Conversation
…ame config IDs (#50246) ## Problem Zed's ACP config-options UI was only rebuilding selectors when the set of config option IDs changed. For many model switches, the IDs stay the same (`mode`, `model`, `reasoning_effort`) while the valid values for `reasoning_effort` change by model. As a result, the picker could show stale values (for example, missing `xhigh` on `gpt-5.3-codex`, or showing extra `xhigh` after switching away). This is especially problematic for providers like Copilot that expose multiple agents/models with different reasoning-level capabilities. ## Fix Rebuild ACP config-option selectors on every `config_option_update`, not only when config IDs change. This refreshes cached picker entries whenever model-specific option values change, even if option IDs are unchanged. ## User Impact - Reasoning-effort picker now reflects the selected model immediately on Claude <-> GPT transitions. - Prevents stale or invalid effort choices in ACP sessions. ## Validation - Manual validation: switch across models with different reasoning-effort sets and confirm picker updates immediately. - Local `cargo check -p agent_ui` remains blocked by unrelated pre-existing `livekit-protocol` compile errors in this checkout. ## Files Changed - `crates/agent_ui/src/acp/config_options.rs` Release Notes: - acp: Fix for config selectors not always being refreshed --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #50246 to stable
Problem
Zed's ACP config-options UI was only rebuilding selectors when the set
of config option IDs changed.
For many model switches, the IDs stay the same (
mode,model,reasoning_effort) while the valid values forreasoning_effortchangeby model. As a result, the picker could show stale values (for example,
missing
xhighongpt-5.3-codex, or showing extraxhighafterswitching away).
This is especially problematic for providers like Copilot that expose
multiple agents/models with different reasoning-level capabilities.
Fix
Rebuild ACP config-option selectors on every
config_option_update, notonly when config IDs change.
This refreshes cached picker entries whenever model-specific option
values change, even if option IDs are unchanged.
User Impact
Claude <-> GPT transitions.
Validation
reasoning-effort sets and confirm picker updates immediately.
cargo check -p agent_uiremains blocked by unrelatedpre-existing
livekit-protocolcompile errors in this checkout.Files Changed
crates/agent_ui/src/acp/config_options.rsRelease Notes:
Co-authored-by: Ben Brandt benjamin.j.brandt@gmail.com