vim: Make :bdelete use new workspace::CloseItemInAllPanes command #48592
Merged
dinocosta merged 6 commits intozed-industries:mainfrom Feb 10, 2026
Merged
vim: Make :bdelete use new workspace::CloseItemInAllPanes command #48592dinocosta merged 6 commits intozed-industries:mainfrom
:bdelete use new workspace::CloseItemInAllPanes command #48592dinocosta merged 6 commits intozed-industries:mainfrom
Conversation
:bdelete uses new workspace::CloseItemInAllPanes command :bdelete use new workspace::CloseItemInAllPanes command
* main: (57 commits) agent: Fix disabled MCP servers disappearing from UI after restart (zed-industries#47758) Update Rust crate git2 to v0.20.4 [SECURITY] (zed-industries#48400) Update Rust crate time to v0.3.47 [SECURITY] (zed-industries#48514) gpui: Reset `external_files_dragged` after successful drag-drop on macOS (zed-industries#48727) language: Return early if no grammars are added (zed-industries#48685) Properly handle multi-char folds (zed-industries#48721) collab: Proxy `GET /extensions` to Cloud (zed-industries#48717) git: Fix a potential misalignment in the side-by-side diff (zed-industries#48690) Move extension API DTOs into `cloud_api_types` (zed-industries#48689) git: Add a setting for the default view mode of `SplittableEditor` (zed-industries#48440) Use proper settings name for semantic tokens' settings UI (zed-industries#48686) gpui: Fix restarting panicking due to double borrows on windows (zed-industries#48667) Strip broken thinking blocks from Anthropic requests (zed-industries#48548) keymap_editor: Add `alt-l` keybinding for cycling favorite models (zed-industries#48390) Only raise Windows timer resolution while blocking with timeout (zed-industries#48379) editor: Propagate `buffer_font_features` to signatureHelp popover (zed-industries#48653) Add configurable LSP timeout setting (zed-industries#44745) editor: Use buffer_font for folds and change foreground color (zed-industries#48652) lsp: Update root_path for compatibility with language servers (zed-industries#48587) Fix panic with LSP folds on disappearing excerpts (zed-industries#48649) ...
Exercise the multi-pane close path by adding a third pane with an item, ensuring `close_pinned: true` actually propagates across multiple panes.
dinocosta
approved these changes
Feb 9, 2026
Member
dinocosta
left a comment
There was a problem hiding this comment.
Thank you @baldwindavid ! 🙂
dinocosta
approved these changes
Feb 10, 2026
3 tasks
osiewicz
added a commit
that referenced
this pull request
Feb 10, 2026
- **Revert "vim: Make `:bdelete` use new `workspace::CloseItemInAllPanes` command (#48592)"** - **Revert "linux: Forward env vars starting with ZED_ to flatpak-spawn (#48118)"** - **ci: Fix builds on hel1-windows-1** - [x] Tests or screenshots needed? - [x] Code Reviewed - [x] Manual QA Release Notes: - N/A
Member
|
This PR has been merged accidentally due to automerge and a screw-up from my side. Ideally we should re-land this. |
3 tasks
morgankrey
added a commit
that referenced
this pull request
Feb 14, 2026
This is an experiment showing what the docs-suggest workflow would have generated for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
morgankrey
added a commit
that referenced
this pull request
Feb 14, 2026
This is an experiment showing what the docs-suggest workflow would have generated for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
morgankrey
added a commit
that referenced
this pull request
Feb 14, 2026
This is an experiment showing what the docs-suggest workflow would have generated for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
morgankrey
added a commit
that referenced
this pull request
Feb 14, 2026
Example output showing what the docs-suggest automation would generate for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Files: - docs/.suggestions/v0.224-suggestions.md: Raw suggestion output - docs/src/update.md: Update notification UI documentation - docs/src/vim.md: Added :bdelete command - docs/src/dev-containers.md: Root config file location support Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
:bd(:bdelete) close a buffer across all panes where it's open, rather than just the current pane.This was mentioned in the "Future Work" section of the recently merged #47079 as a supporting feature.
This matches Helix's
:bc(:bclose) behavior. In vanilla Vim,:bdeletecloses all windows displaying the buffer, which many users find disruptive—hence popular plugins and keybinding workarounds that preserve window layout. This implementation aligns with this behavior: the buffer is removed from all panes, but panes remain open (showing another tab, or closing only if empty). This is also a better fit for Zed since buffers are inextricably tied to panes so closing the entire pane may mistakenly close a bunch of buffers.Also refactors the tab switcher's close button to leverage this command.
Release Notes:
:bd(:bdelete) now closes the file in all panes where it's openworkspace::CloseItemInAllPanesaction to close a file across all panes