linux: Forward env vars starting with ZED_ to flatpak-spawn#48118
linux: Forward env vars starting with ZED_ to flatpak-spawn#48118ConradIrwin merged 1 commit intozed-industries:mainfrom
Conversation
Otherwise, it's not easily possible to set *any* of these variables when running Zed.
|
Thanks for this! What are the env vars you need? I'm wondering if they should just be settings to avoid breaking the assumption that flatpak gives you isolated environments. |
Mostly
Note that as-is, Flatpak does not actually remove environment variables: So it's actually a bit of an abnormality that, when using flatpak-spawn here, the ZED_ vars don't get forwarded. |
|
That is weird... are we disabling them somewhere? |
|
It's not really about it being disabled..,explicitly at least. Consider that the launch flow, when not staying within the sandbox, is: flatpak -> zed (inside sandbox) -> Flatpak passes most environment variables into the sandbox, so |
|
ok, sorry for not figuring that out. Makes sense |
- **Revert "vim: Make `:bdelete` use new `workspace::CloseItemInAllPanes` command (#48592)"** - **Revert "linux: Forward env vars starting with ZED_ to flatpak-spawn (#48118)"** - **ci: Fix builds on hel1-windows-1** - [x] Tests or screenshots needed? - [x] Code Reviewed - [x] Manual QA Release Notes: - N/A
|
This PR has been merged accidentally due to automerge and a screw-up from my side. Ideally we should re-land this. |
This is an experiment showing what the docs-suggest workflow would have generated for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This is an experiment showing what the docs-suggest workflow would have generated for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
This is an experiment showing what the docs-suggest workflow would have generated for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Example output showing what the docs-suggest automation would generate for the v0.224 preview release. PRs analyzed: - #48118: Forward ZED_ env vars to flatpak (no docs needed) - #48467: Move update button to title bar (docs needed) - #48553: Tool permissions refactor (docs exist, wrong format) - #48592: vim :bdelete command (docs needed) - #48814: Devcontainer root support (docs needed) - #48912: Split diff default (docs needed) 5 of 6 PRs generated actionable suggestions. Files: - docs/.suggestions/v0.224-suggestions.md: Raw suggestion output - docs/src/update.md: Update notification UI documentation - docs/src/vim.md: Added :bdelete command - docs/src/dev-containers.md: Root config file location support Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Otherwise, it's not easily possible to set any of these variables when running Zed.
Release Notes:
ZED_*environment variables when using the Flatpak