Skip to content

git_ui: Hide "View on GitHub" button when viewing stashes in commit view#48271

Merged
cole-miller merged 1 commit intozed-industries:mainfrom
amtoaer:fix_stash_view
Feb 3, 2026
Merged

git_ui: Hide "View on GitHub" button when viewing stashes in commit view#48271
cole-miller merged 1 commit intozed-industries:mainfrom
amtoaer:fix_stash_view

Conversation

@amtoaer
Copy link
Contributor

@amtoaer amtoaer commented Feb 3, 2026

Closes #48195

Filter out remote_info when viewing stashes by adding .filter(|_| self.stash.is_none()).

Release Notes:

  • Fixed "View on GitHub" button incorrectly appearing when viewing stashes

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 3, 2026
@github-actions github-actions bot added the community champion Issues filed by our amazing community champions! 🫶 label Feb 3, 2026
@cole-miller
Copy link
Member

Thanks!

@cole-miller cole-miller enabled auto-merge (squash) February 3, 2026 17:37
@cole-miller cole-miller merged commit 1b86dbc into zed-industries:main Feb 3, 2026
29 checks passed
adb-sh pushed a commit to adb-sh/zed that referenced this pull request Feb 5, 2026
…iew (zed-industries#48271)

Closes zed-industries#48195

Filter out `remote_info` when viewing stashes by adding `.filter(|_|
self.stash.is_none())`.


Release Notes:

- Fixed "View on GitHub" button incorrectly appearing when viewing
stashes
rtfeldman pushed a commit that referenced this pull request Feb 5, 2026
…iew (#48271)

Closes #48195

Filter out `remote_info` when viewing stashes by adding `.filter(|_|
self.stash.is_none())`.


Release Notes:

- Fixed "View on GitHub" button incorrectly appearing when viewing
stashes
naaiyy added a commit to Glass-HQ/Glass that referenced this pull request Feb 16, 2026
Key changes:
- Reduce monomorphizations in GPUI app.rs (zed-industries#48014)
- Entities no longer implement Element directly, go through AnyElement (zed-industries#48217)
- D3D11 resource upload optimization (zed-industries#48282)
- Migrate features.edit_prediction_provider to edit_predictions.provider (zed-industries#48224)
- Make mercury and sweep non-experimental (zed-industries#48227)
- CompanionView consolidation in block_map (zed-industries#48223)
- Show memory used by language servers (zed-industries#48226)
- Settings links open sub pages (zed-industries#48212)
- Tool security rules that can't be overridden (zed-industries#48209)
- Add sweep_ai privacy mode setting (zed-industries#48220)
- Configurable REPL output size limits (zed-industries#47114)
- Fix .editorconfig files in subdirectories (zed-industries#48203)
- Security updates: bytes v1.11.1, jsonwebtoken v10
- Git UI: hide "View on GitHub" for stashes (zed-industries#48271)
- Indent guide fix in tree view with collapsed folders (zed-industries#48194)
- Edit prediction fixes and improvements

Conflict resolution:
- collab/completion.rs, collab/rpc.rs: deleted (collab removed)
- vim/search.rs: deleted (vim removed)
- livekit_api/Cargo.toml: deleted (livekit removed)
- GPUI files: deleted from Glass (handled in Obsydian-HQ/gpui)
- migrations: combined both ours (m_2026_02_06) and upstream (m_2026_02_02, m_2026_02_03)
- project.rs: kept collab functions removed, restored handle_create_file_for_peer for remote dev
- lsp_store.rs: removed collab-only set_language_server_statuses_from_proto
- proto.rs: kept CreateFileForPeer, removed CreateChannel/CreateChannelResponse
- remote_servers.rs: merged import lists (kept native button imports + added Action)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement community champion Issues filed by our amazing community champions! 🫶

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove View on GitHub feature from stash view

2 participants