Skip to content

Added support for dismissing the toolchain path selector via esc#48201

Merged
JosephTLyons merged 1 commit intomainfrom
Allow-dismissing-toolchain-path-selector
Feb 2, 2026
Merged

Added support for dismissing the toolchain path selector via esc#48201
JosephTLyons merged 1 commit intomainfrom
Allow-dismissing-toolchain-path-selector

Conversation

@JosephTLyons
Copy link
Collaborator

Release Notes:

  • Added support for dismissing the toolchain path selector via esc.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Feb 2, 2026
@JosephTLyons JosephTLyons enabled auto-merge (squash) February 2, 2026 16:48
@JosephTLyons JosephTLyons merged commit 174fc51 into main Feb 2, 2026
29 checks passed
@JosephTLyons JosephTLyons deleted the Allow-dismissing-toolchain-path-selector branch February 2, 2026 16:56
adb-sh pushed a commit to adb-sh/zed that referenced this pull request Feb 5, 2026
…ed-industries#48201)

Release Notes:

- Added support for dismissing the toolchain path selector via `esc`.
polyesterswing added a commit to polyesterswing/zed that referenced this pull request Feb 18, 2026
…`esc` (zed-industries#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a path

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, the dialog is immediately dismissed, and the path is never resolved or made available
polyesterswing added a commit to polyesterswing/zed that referenced this pull request Feb 18, 2026
…`esc` (zed-industries#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State
- This prevents the selected toolchain from being resolved and the ScopePicker being presented
JosephTLyons pushed a commit that referenced this pull request Feb 18, 2026
#49504)

…`esc` (#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent,
and it goes to the Search State
- This prevents the selected toolchain from being resolved and the
ScopePicker being presented

cc: @JosephTLyons 

Release Notes:

- Fixed a regression where the toolchain path selector would immediately
dismiss upon selecting a path, preventing the addition of new
toolchains.
github-actions bot pushed a commit that referenced this pull request Feb 18, 2026
#49504)

…`esc` (#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent,
and it goes to the Search State
- This prevents the selected toolchain from being resolved and the
ScopePicker being presented

cc: @JosephTLyons 

Release Notes:

- Fixed a regression where the toolchain path selector would immediately
dismiss upon selecting a path, preventing the addition of new
toolchains.
github-actions bot pushed a commit that referenced this pull request Feb 18, 2026
#49504)

…`esc` (#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent,
and it goes to the Search State
- This prevents the selected toolchain from being resolved and the
ScopePicker being presented

cc: @JosephTLyons 

Release Notes:

- Fixed a regression where the toolchain path selector would immediately
dismiss upon selecting a path, preventing the addition of new
toolchains.
zed-zippy bot added a commit that referenced this pull request Feb 18, 2026
#49504) (cherry-pick to stable) (#49529)

Cherry-pick of #49504 to stable

----
…`esc` (#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent,
and it goes to the Search State
- This prevents the selected toolchain from being resolved and the
ScopePicker being presented

cc: @JosephTLyons 

Release Notes:

- Fixed a regression where the toolchain path selector would immediately
dismiss upon selecting a path, preventing the addition of new
toolchains.

Co-authored-by: Kurian Jojo <67583328+polyesterswing@users.noreply.github.com>
zed-zippy bot added a commit that referenced this pull request Feb 18, 2026
#49504) (cherry-pick to preview) (#49528)

Cherry-pick of #49504 to preview

----
…`esc` (#48201)"

This reverts commit 174fc51.

Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains

- OpenPathDelegate emits DismissEvents in the `confirm` function too
- when the selection is confirmed, DismissEvent is emitted
- ToolchainSelector calls cancel because it receives the DismissEvent,
and it goes to the Search State
- This prevents the selected toolchain from being resolved and the
ScopePicker being presented

cc: @JosephTLyons 

Release Notes:

- Fixed a regression where the toolchain path selector would immediately
dismiss upon selecting a path, preventing the addition of new
toolchains.

Co-authored-by: Kurian Jojo <67583328+polyesterswing@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant