Revert "Added support for dismissing the toolchain path selector via … (#49504) (cherry-pick to preview)#49528
Merged
zed-zippy[bot] merged 1 commit intov0.225.xfrom Feb 18, 2026
Conversation
#49504) …`esc` (#48201)" This reverts commit 174fc51. Select toolchain path dialog immediately dismisses upon selecting a path, preventing the addition of new toolchains - OpenPathDelegate emits DismissEvents in the `confirm` function too - when the selection is confirmed, DismissEvent is emitted - ToolchainSelector calls cancel because it receives the DismissEvent, and it goes to the Search State - This prevents the selected toolchain from being resolved and the ScopePicker being presented cc: @JosephTLyons Release Notes: - Fixed a regression where the toolchain path selector would immediately dismiss upon selecting a path, preventing the addition of new toolchains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #49504 to preview
…
esc(#48201)"This reverts commit 174fc51.
Select toolchain path dialog immediately dismisses upon selecting a
path, preventing the addition of new toolchains
confirmfunction tooand it goes to the Search State
ScopePicker being presented
cc: @JosephTLyons
Release Notes:
dismiss upon selecting a path, preventing the addition of new
toolchains.