Enable configurable dismissal of language server notifications that do not require user interaction#46708
Merged
SomeoneToIgnore merged 3 commits intozed-industries:mainfrom Jan 22, 2026
Conversation
6c2ac49 to
2cf1a54
Compare
c67401a to
80f793f
Compare
SomeoneToIgnore
approved these changes
Jan 22, 2026
Contributor
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
Looks great, I will push the documentation changes in the few hours, thank you for your persistence and work.
| .dismiss_timeout_ms; | ||
|
|
||
| if is_prompt_without_actions { | ||
| if let Some(dismiss_duration_ms) = dismiss_timeout_ms.filter(|&ms| ms > 0) { |
Contributor
There was a problem hiding this comment.
Nice addition.
Not sure we need to do anything now, but noticing that with this approach, we're not getting any settings change propagated to existing notifications.
Some transitions in settings (from "no timeouts" to "some quick timeout" and, presumably, back) may be confusing for users — let's see what the feedback comes.
dde05e3 to
2798ec4
Compare
zcg
pushed a commit
to zcg/zedpro
that referenced
this pull request
Jan 29, 2026
…o not require user interaction (zed-industries#46708) Closes zed-industries#38769 Release Notes: - Dismiss server notifications automatically with `"global_lsp_settings": { "notifications": { "dismiss_timeout_ms": 5000 } }` settings defaults. --------- Co-authored-by: Kirill Bulatov <kirill@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38769
Release Notes:
"global_lsp_settings": { "notifications": { "dismiss_timeout_ms": 5000 } }settings defaults.