workspace: Remove custom-positioned modal placement logic#46047
Merged
danilo-leal merged 1 commit intomainfrom Jan 5, 2026
Merged
workspace: Remove custom-positioned modal placement logic#46047danilo-leal merged 1 commit intomainfrom
danilo-leal merged 1 commit intomainfrom
Conversation
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
This PR essentially removes the logic I introduced in #45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in #45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ries#46047) This PR essentially removes the logic I introduced in zed-industries#45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in zed-industries#45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ries#46047) This PR essentially removes the logic I introduced in zed-industries#45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in zed-industries#45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
…ries#46047) This PR essentially removes the logic I introduced in zed-industries#45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in zed-industries#45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR essentially removes the logic I introduced in #45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in #45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handles all the anchor positioning based on the trigger (and that's much better).
Release Notes: