title_bar: Use popovers for modal anchoring#45924
Merged
danilo-leal merged 12 commits intozed-industries:mainfrom Jan 4, 2026
Merged
title_bar: Use popovers for modal anchoring#45924danilo-leal merged 12 commits intozed-industries:mainfrom
danilo-leal merged 12 commits intozed-industries:mainfrom
Conversation
Two versions of the branch picker popover. Simplified and Full
create_new_window doesn't make sense as a variable name for what the variable did which was dictate how new projects were opened.
danilo-leal
approved these changes
Jan 4, 2026
Member
danilo-leal
left a comment
There was a problem hiding this comment.
Thanks for the follow up! I've pushed a few commits cleaning up/simplifying this to the core change: making the modal use popovers when triggered through by a pointer. Slightly unsure whether the added dependencies are worth it, but I suppose it's what it takes for now... in any case, thanks again!
danilo-leal
added a commit
that referenced
this pull request
Jan 5, 2026
This PR essentially removes the logic I introduced in #45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in #45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
Anchoring fix part of #45853 Before: https://github.com/user-attachments/assets/abe66049-04e5-4f33-9efb-2e99e63e4cc8 After: https://github.com/user-attachments/assets/14533bbe-8f46-43b1-9465-11e8d313561f Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
rtfeldman
pushed a commit
that referenced
this pull request
Jan 5, 2026
This PR essentially removes the logic I introduced in #45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in #45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Anchoring fix part of zed-industries#45853 Before: https://github.com/user-attachments/assets/abe66049-04e5-4f33-9efb-2e99e63e4cc8 After: https://github.com/user-attachments/assets/14533bbe-8f46-43b1-9465-11e8d313561f Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ries#46047) This PR essentially removes the logic I introduced in zed-industries#45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in zed-industries#45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
Anchoring fix part of zed-industries#45853 Before: https://github.com/user-attachments/assets/abe66049-04e5-4f33-9efb-2e99e63e4cc8 After: https://github.com/user-attachments/assets/14533bbe-8f46-43b1-9465-11e8d313561f Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Jan 20, 2026
…ries#46047) This PR essentially removes the logic I introduced in zed-industries#45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in zed-industries#45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
Anchoring fix part of zed-industries#45853 Before: https://github.com/user-attachments/assets/abe66049-04e5-4f33-9efb-2e99e63e4cc8 After: https://github.com/user-attachments/assets/14533bbe-8f46-43b1-9465-11e8d313561f Release Notes: - N/A --------- Co-authored-by: Danilo Leal <daniloleal09@gmail.com>
LivioGama
pushed a commit
to LivioGama/zed
that referenced
this pull request
Feb 15, 2026
…ries#46047) This PR essentially removes the logic I introduced in zed-industries#45361 to position workspace modals based on the pointer click coordinates. All of this code has become unnecessary given in zed-industries#45924 we made the remote, project, and branch modals use popovers when triggered with a pointer, which already handle all the anchored positioning based on the trigger (much better). Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchoring fix part of #45853
Before:
Screen.Recording.2025-12-30.at.3.22.15.PM.mov
After:
Screen.Recording.2025-12-31.at.8.19.32.PM.mov
Release Notes: