Apply show_completions_on_input: false to word & snippet completions#44021
Merged
Apply show_completions_on_input: false to word & snippet completions#44021
show_completions_on_input: false to word & snippet completions#44021Conversation
Previously it was inside `is_completion_trigger` but now it's in `open_or_update_completions_menu` so it applies to all completions instead of just LSP.
benbrandt
added a commit
that referenced
this pull request
Dec 5, 2025
…completions_on_input set to false Addresses a regression introduced by #44021 that caused @mentions and slash commands to stop working if you set `show_completions_on_input: false` in your settings. In this case, we should always show these menus, otherwise the features won't work at all.
benbrandt
added a commit
that referenced
this pull request
Dec 5, 2025
…completions_on_input set to false (#44222) Addresses a regression introduced by #44021 that caused @mentions and slash commands to stop working if you set `show_completions_on_input: false` in your settings. In this case, we should always show these menus, otherwise the features won't work at all. Release Notes: - N/A
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
…completions_on_input set to false (#44222) Addresses a regression introduced by #44021 that caused @mentions and slash commands to stop working if you set `show_completions_on_input: false` in your settings. In this case, we should always show these menus, otherwise the features won't work at all. Release Notes: - N/A
zed-zippy bot
added a commit
that referenced
this pull request
Dec 5, 2025
…completions_on_input set to false (#44222) (cherry-pick to preview) (#44224) Cherry-pick of #44222 to preview ---- Addresses a regression introduced by #44021 that caused @mentions and slash commands to stop working if you set `show_completions_on_input: false` in your settings. In this case, we should always show these menus, otherwise the features won't work at all. Release Notes: - N/A Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
zed-industries#44021) Closes zed-industries#43408 Previously, we checked the setting inside `is_completion_trigger()`, which only affects LSP completions. This was ok because user-defined snippets were tacked onto LSP completions. Then zed-industries#42122 and zed-industries#42398 made snippet completions their own thing, similar to word completions, surfacing zed-industries#43408. This PR moves the settings check into `open_or_update_completions_menu()` so it applies to all completions. Release Notes: - Fixed setting `show_completions_on_input: false` so that it affects word and user-defined snippet completions as well as LSP completions
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
…completions_on_input set to false (zed-industries#44222) Addresses a regression introduced by zed-industries#44021 that caused @mentions and slash commands to stop working if you set `show_completions_on_input: false` in your settings. In this case, we should always show these menus, otherwise the features won't work at all. Release Notes: - N/A
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
zed-industries#44021) Closes zed-industries#43408 Previously, we checked the setting inside `is_completion_trigger()`, which only affects LSP completions. This was ok because user-defined snippets were tacked onto LSP completions. Then zed-industries#42122 and zed-industries#42398 made snippet completions their own thing, similar to word completions, surfacing zed-industries#43408. This PR moves the settings check into `open_or_update_completions_menu()` so it applies to all completions. Release Notes: - Fixed setting `show_completions_on_input: false` so that it affects word and user-defined snippet completions as well as LSP completions
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
…completions_on_input set to false (zed-industries#44222) Addresses a regression introduced by zed-industries#44021 that caused @mentions and slash commands to stop working if you set `show_completions_on_input: false` in your settings. In this case, we should always show these menus, otherwise the features won't work at all. Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #43408
Previously, we checked the setting inside
is_completion_trigger(), which only affects LSP completions. This was ok because user-defined snippets were tacked onto LSP completions. Then #42122 and #42398 made snippet completions their own thing, similar to word completions, surfacing #43408. This PR moves the settings check intoopen_or_update_completions_menu()so it applies to all completions.Release Notes:
show_completions_on_input: falseso that it affects word and user-defined snippet completions as well as LSP completions