Conversation
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
Also optimize `words_min_length` check to only count as many chars as necessary
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
|
This has caused it so that completions appear when the initial characters match the initials of one of my saved snippets even when I have set I don't know if this is intentional or a regression, but when I have Edit: I do not have proof that this is what caused the sudden behavior change, but it's the change related to auto completions. |
11happy
pushed a commit
to 11happy/zed
that referenced
this pull request
Dec 1, 2025
This is progress toward multi-word snippets (including snippets with prefixes containing symbols) Release Notes: - Removed `trigger` argument in `ShowCompletions` command --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
HactarCE
added a commit
that referenced
this pull request
Dec 2, 2025
#44021) Closes #43408 Previously, we checked the setting inside `is_completion_trigger()`, which only affects LSP completions. This was ok because user-defined snippets were tacked onto LSP completions. Then #42122 and #42398 made snippet completions their own thing, similar to word completions, surfacing #43408. This PR moves the settings check into `open_or_update_completions_menu()` so it applies to all completions. Release Notes: - Fixed setting `show_completions_on_input: false` so that it affects word and user-defined snippet completions as well as LSP completions
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
zed-industries#44021) Closes zed-industries#43408 Previously, we checked the setting inside `is_completion_trigger()`, which only affects LSP completions. This was ok because user-defined snippets were tacked onto LSP completions. Then zed-industries#42122 and zed-industries#42398 made snippet completions their own thing, similar to word completions, surfacing zed-industries#43408. This PR moves the settings check into `open_or_update_completions_menu()` so it applies to all completions. Release Notes: - Fixed setting `show_completions_on_input: false` so that it affects word and user-defined snippet completions as well as LSP completions
someone13574
pushed a commit
to someone13574/zed
that referenced
this pull request
Dec 16, 2025
zed-industries#44021) Closes zed-industries#43408 Previously, we checked the setting inside `is_completion_trigger()`, which only affects LSP completions. This was ok because user-defined snippets were tacked onto LSP completions. Then zed-industries#42122 and zed-industries#42398 made snippet completions their own thing, similar to word completions, surfacing zed-industries#43408. This PR moves the settings check into `open_or_update_completions_menu()` so it applies to all completions. Release Notes: - Fixed setting `show_completions_on_input: false` so that it affects word and user-defined snippet completions as well as LSP completions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is progress toward multi-word snippets (including snippets with prefixes containing symbols)
Release Notes:
triggerargument inShowCompletionscommand