Skip to content

themes: Improve One terminal colors#38992

Closed
dangooddd wants to merge 1 commit intozed-industries:mainfrom
dangooddd:onedark-term-colors
Closed

themes: Improve One terminal colors#38992
dangooddd wants to merge 1 commit intozed-industries:mainfrom
dangooddd:onedark-term-colors

Conversation

@dangooddd
Copy link
Contributor

@dangooddd dangooddd commented Sep 26, 2025

Continuation of related PR #38536.
Similar issues - currently normal, bright and dim colors all mixed up wrong.

I made Normal and Bright colors be the same with only Black and White color differs, as in all other terminal themes (alacritty and ghostty and original Atom text editor, for example).

Before After
image image

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 26, 2025
@dangooddd
Copy link
Contributor Author

@osyvokon Hello! Any updates on this? Want to know, could I start working on similar change for Ayu theme?

@osyvokon
Copy link
Contributor

Hey @dangooddd! A couple of notes:

  1. The bright white color is currently broken (there's an extra character in the color spec)

  2. I'd prefer keep bright and normal colors different, given that this is a default theme. While many implementations do merge them, others (e.g., VSCode's "Atom One Dark") push the bright colors just a bit lighter. Let's take a similar approach.

@zelenenka
Copy link
Contributor

@dangooddd have you had a chance to look at @osyvokon's feedback? do you have any questions?

@dangooddd
Copy link
Contributor Author

@zelenenka I agree with changes that @osyvokon suggested. Unfortunately, I do not have time to do this anytime soon. If anyone can complete this PR, I will really appreciate this!

@osyvokon osyvokon assigned osyvokon and mattermill and unassigned mattermill and osyvokon Dec 15, 2025
@github-project-automation github-project-automation bot moved this from Community PRs to Done in Quality Week – December 2025 Dec 15, 2025
pull bot pushed a commit to appelgriebsch/zed that referenced this pull request Dec 15, 2025
Closes zed-industries#38992 

Release Notes:

- N/A

---------

Co-authored-by: dangooddd <dangoodds@gmail.com>
CherryWorm pushed a commit to CherryWorm/zed that referenced this pull request Dec 16, 2025
Closes zed-industries#38992 

Release Notes:

- N/A

---------

Co-authored-by: dangooddd <dangoodds@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

Development

Successfully merging this pull request may close these issues.

4 participants