This should also be done for many other themes as well. Inversed bright/normal colors makes many terminal apps looks very awful, and sometimes not readable at all.

Thanks for opening this PR. It looks reasonable and color codes 90..97 do appear to be swapped with dimmed colors. Unfortunately, while checking the changes, I've run into a few weird things.

First, the terminal colors feel off with this change -- the white is too white:

Second, it seems like dimmed colors are not really respected by Zed's terminal:

Zed, with or without this PR:

VSCode:

WezTerm:

Finally, I'm not sure why rendering ANSI code 90..97 differs so much from rendering bright colors with the 1; prefix (as in the script below) in Zed.

def print_colors():
    colors = [
        ("Black", 30),
        ("Red", 31),
        ("Green", 32),
        ("Yellow", 33),
        ("Blue", 34),
        ("Magenta", 35),
        ("Cyan", 36),
        ("White", 37),
    ]

    print(f"{'Color':<10} {'Normal':<15} {'Bright':<15} {'Dim':<15}")
    print("-" * 60)

    for color_name, color_code in colors:
        normal = f"\033[{color_code}m{color_name}\033[0m"
        bright = f"\033[1;{color_code}m{color_name}\033[0m"
        dim = f"\033[2;{color_code}m{color_name}\033[0m"

        print(f"{color_name:<10} {normal:<25} {bright:<25} {dim:<25}")

The last two points are not really related to this PR, but they add confusion and make it harder to review. I think I need more time to figure out what's going on.

Problem is that in my case all the colors differs from yours, and I do not know why.
Output of your script looks like this in my case:

As you can see, in my case dim colors is respected by zed, but I think we could make them more dimmed.
What is strange is that my foreground color is not white as yours also, and looks normal. We can change bright_foreground to different color, for example fg1 from original palette.

Something wrong with how zed renders colors in terminal, but I agree with you that this is not related to this PR.

Problem with terminal colors also appears on One Dark theme (some colors inverted and some not). Should I open new pull request for that theme once I figured out which colors we could consider? @osyvokon

@dangooddd, yeah, I'd appreciate it if you could fix One Dark as well.

I haven't had a chance to debug the unnatural whiteness issue yet, but I'll tackle it in the next few days. After that, I'll either merge this PR, or make a fix and merge.

And Ayu needs this fix as well. I will deep in Ayu later.

Okay, I found the problem with the foreground color being too white: the terminal.foreground values contain an extra byte (ff). Not sure how it was working on your machine.

Removing it makes things a bit better, but now the foreground becomes too gray. I think we should keep it equal to editor.foreground (#ebdbb2ff).

If you're open to hopping on a call to go through all three themes (One, Aya, Gruvbox) together, feel free to book a time here.

I feel you can just tweak it how you like! The only thing we need to fix is messed up dim/normal/bright colors.

@osyvokon I fixed dark themes, now all should be fine with them. Please check latest commit with changes to light themes. I did them match original gruvbox themes + fix current normal/bright colors issue. In original theme ANSI black is actually light (like editor background), and ANSI white is actually dark (like editor foreground). Let me known if you think we should keep ANSI black - dark and ANSI white - light, but IMO original gruvbox approach is better when using CLI/TUI

Looks good to me. Thanks for the fix!

In my opinion, this change makes the text less legible. The screenshot is using Gruvbox Light Soft on macOS.

The text looks overly vibrant and doesn’t use the same colors as the main editor.

I believe the built-in themes were generated with a specific design intention and aren’t meant to be edited by hand. This should have been addressed either by creating a custom theme or by updating the theme generation script so everything stays consistent.

Sorry that this affects you. I can not find any theme generation script in repo, thats potentially my fault. But this PR solves issue with broken normal/bright/dim colors that was a must. As zed uses standard gruvbox background colors in all themes, and I made terminal colors match original gruvbox, this should be pretty much how original design of gruvbox looks