Always strip preceding / from path in ManifestStore#764
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 35 35
Lines 1848 1848
=======================================
Hits 1618 1618
Misses 230 230
🚀 New features to boost your workflow:
|
TomNicholas
approved these changes
Aug 9, 2025
Member
Author
Yes, v0.8.0 included a breaking change that requires users to ensure paths are valid - https://developmentseed.org/obstore/latest/CHANGELOG/#whats-changed |
maxrjones
added a commit
that referenced
this pull request
Aug 9, 2025
* Always strip preceding / from path in ManifestStore * Fix docs error
TomNicholas
added a commit
that referenced
this pull request
Aug 14, 2025
* Unpin xarray * Fix Icechunk tests with xarray 2025.07.0 * Simplify test_set_grid_virtual_refs * Always strip preceding / from path in ManifestStore * Fix docs error * Consolidate into fixture * Simplify some append icechunk tests * Always strip preceding / from path in ManifestStore (#764) * Always strip preceding / from path in ManifestStore * Fix docs error * Add xarray to upstream * Refactor icechunk append tests * Update offset in DMR++ tests * Update virtualizarr/tests/test_writers/test_icechunk.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use same minimum version of xarray that we used before pinning it * add release note * move new test fixtures to conftest.py * move fixture I missed --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Tom Nicholas <tom@earthmover.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obstore expects the preceding '/' to be stripped.
docs/releases.rstapi.rst