Merged
Conversation
TomNicholas
reviewed
Aug 13, 2025
Comment on lines
+57
to
+58
| @pytest.fixture() | ||
| def synthetic_vds(tmpdir: Path): |
Member
There was a problem hiding this comment.
You realise that we could replace the use of netCDF files in a huge number of our other tests with these??? For now let's just put these fixtures outside of test_icechunk.py so we can consolidate them later, because nothing about these is specific to icechunk.
maxrjones
commented
Aug 13, 2025
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
=======================================
Coverage 87.71% 87.71%
=======================================
Files 35 35
Lines 1872 1872
=======================================
Hits 1642 1642
Misses 230 230 🚀 New features to boost your workflow:
|
TomNicholas
approved these changes
Aug 13, 2025
7 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the failures on xarray>=2025.7.1. The tests are failing because pydata/xarray@3679a5d changes the contents of NetCDF files written by xarray. I addressed these failures in two ways:
Checklist
docs/releases.rst