Remove unnecessary dtype conversion in icechunk writer#760
Merged
maxrjones merged 4 commits intozarr-developers:mainfrom Sep 3, 2025
popododo0720:fix-unnecessary-dtype-conversion
Merged
Remove unnecessary dtype conversion in icechunk writer#760maxrjones merged 4 commits intozarr-developers:mainfrom popododo0720:fix-unnecessary-dtype-conversion
maxrjones merged 4 commits intozarr-developers:mainfrom
popododo0720:fix-unnecessary-dtype-conversion
Conversation
Member
|
@d-v-b your suggestion led our new contributor astray! I think the error here might be actually indicative of an issue in zarr-python. I notice that the |
|
yes that's a zarr-python bug -- it looks like |
Member
|
I'm confused what fixed this? |
Member
#765 fixed the failing test. We were previously testing for a scenario in which the ArrayV3Metadata contains a numpy dtype, which should not occur since 3.1.0 and the use of ZDtype in the ArrayV3Metadata structure. |
TomNicholas
added a commit
that referenced
this pull request
Sep 24, 2025
This reverts commit 4c3c4fd.
maxrjones
pushed a commit
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/releases.rst(minor internal change)api.rst(no new functions)Description
Removed unnecessary
.to_native_dtype()conversion in icechunk writer as suggested by @d-v-b in #758.Now passing
metadata.data_typedirectly.Changes
VirtualiZarr/virtualizarr/writers/icechunk.pyline 347This is my first contribution!