Fix #818: Revert to using canAddNotes#827
Merged
jamesmaa merged 1 commit intoyomidevs:masterfrom Apr 16, 2024
eloyrobillard:revert-to-can-add-notes
Merged
Fix #818: Revert to using canAddNotes#827jamesmaa merged 1 commit intoyomidevs:masterfrom eloyrobillard:revert-to-can-add-notes
jamesmaa merged 1 commit intoyomidevs:masterfrom
eloyrobillard:revert-to-can-add-notes
Conversation
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
Kuuuube
approved these changes
Apr 16, 2024
Member
Kuuuube
left a comment
There was a problem hiding this comment.
Looks good, works in my testing.
jamesmaa
approved these changes
Apr 16, 2024
Collaborator
jamesmaa
left a comment
There was a problem hiding this comment.
My fairly rubberstamp approval. LGTM
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* added Old Irish (SGA) * Merge Yomitan Updates (#1) * fix (#811) * Add scanOnTouchTap and improve touch scanning defaults (#791) * Add scanOnTouchTap * Update version to 30 * Cleanup if statement * log anki error when hiding button (#821) * Fix noteInfos not getting assigned (#819) * improve term sorting (#806) * improve term sorting * edge case * fix: add missing handlebar entry (#823) * fix: add missing handlebar entry * fix: add new handlebar to tests * Revert to using canAddNotes (#827) Fix #818 * Remove unused canAdd (#824) Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local> * Fix duplicate check not working across note types (#830) * Fix duplicate check not working across note types * Add invalidNoteId --------- Co-authored-by: James Maa <jmaa@berkeley.edu> --------- Co-authored-by: StefanVukovic99 <stefanvukovic44@gmail.com> Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Co-authored-by: m-edlund <me@fwegmann.com> Co-authored-by: Eloy Robillard <eloy.robillard@gmail.com> Co-authored-by: James Maa <jmaa@berkeley.edu> Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local> * Revert "Merge Yomitan Updates (#1)" This reverts commit 748dc22. * Fix Static Analysis Error * Fix eslint erro --------- Co-authored-by: martholomew <martholomew@users.noreply.github.com> Co-authored-by: StefanVukovic99 <stefanvukovic44@gmail.com> Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Co-authored-by: m-edlund <me@fwegmann.com> Co-authored-by: Eloy Robillard <eloy.robillard@gmail.com> Co-authored-by: James Maa <jmaa@berkeley.edu> Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local>
|
Hey guys im not that technical, it seems like you guys found a fix but im not sure how to implement the fix? |
Member
You dont. Update yomitan and the fix will be there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #818.
Reverting to using canAddNotes to avoid issues for users with older AnkiConnect version not supporting
canAddNotesWithErrorDetail(introduced in 24.1.21.0).Test plan
To simulate the original issue:
Anki2/addons21/2055492159, can be reached from Anki by going toAdd-ons>AnkiConnect>Show files)__init__.py, comment out thecanAddNotesWithErrorDetailmethod from line 791 to 801 in the latest versionCheck for card duplicatesis on in the Yomitan settings