Add scanOnTouchTap and improve touch scanning defaults#791
Merged
jamesmaa merged 3 commits intoyomidevs:masterfrom Apr 14, 2024
Merged
Add scanOnTouchTap and improve touch scanning defaults#791jamesmaa merged 3 commits intoyomidevs:masterfrom
jamesmaa merged 3 commits intoyomidevs:masterfrom
Conversation
|
View Playwright Report (note: open the "playwright-report" artifact) |
StefanVukovic99
previously approved these changes
Apr 10, 2024
Member
StefanVukovic99
left a comment
There was a problem hiding this comment.
LGTM (has a conflict though)
Member
Author
Resolved |
StefanVukovic99
approved these changes
Apr 10, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* added Old Irish (SGA) * Merge Yomitan Updates (#1) * fix (#811) * Add scanOnTouchTap and improve touch scanning defaults (#791) * Add scanOnTouchTap * Update version to 30 * Cleanup if statement * log anki error when hiding button (#821) * Fix noteInfos not getting assigned (#819) * improve term sorting (#806) * improve term sorting * edge case * fix: add missing handlebar entry (#823) * fix: add missing handlebar entry * fix: add new handlebar to tests * Revert to using canAddNotes (#827) Fix #818 * Remove unused canAdd (#824) Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local> * Fix duplicate check not working across note types (#830) * Fix duplicate check not working across note types * Add invalidNoteId --------- Co-authored-by: James Maa <jmaa@berkeley.edu> --------- Co-authored-by: StefanVukovic99 <stefanvukovic44@gmail.com> Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Co-authored-by: m-edlund <me@fwegmann.com> Co-authored-by: Eloy Robillard <eloy.robillard@gmail.com> Co-authored-by: James Maa <jmaa@berkeley.edu> Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local> * Revert "Merge Yomitan Updates (#1)" This reverts commit 748dc22. * Fix Static Analysis Error * Fix eslint erro --------- Co-authored-by: martholomew <martholomew@users.noreply.github.com> Co-authored-by: StefanVukovic99 <stefanvukovic44@gmail.com> Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Co-authored-by: m-edlund <me@fwegmann.com> Co-authored-by: Eloy Robillard <eloy.robillard@gmail.com> Co-authored-by: James Maa <jmaa@berkeley.edu> Co-authored-by: James Maa <jamesmaa@Jamess-MacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current touch scanning options are extremely prone to accidental scans. Scrolling down a webpage or flipping a page in a book can get very annoying when every 2 seconds theres an accidental scan.
In the past with yomichan there were some very specific settings that could be used as a workaround to fix this and effectively get a touch tap gesture. Yomitan no longer allows this workaround. I looked into restoring this behavior and it turns out that behavior being possible was actually exploiting a bug and it's also a pain to set up anyways.
I've added
scanOnTouchTapso we can have proper touch tap gesture support. The implementation is simple:touchstart -> touchend = touchtaptouchstart -> touchmove -> touchend = no touchtapI've also made this update settings to disable the previous defaults:
scanOnTouchPressandscanOnTouchMove. Normally I wouldn't want to mess with existing settings like this but the previous defaults were so bad to use compared to this I think it's a worthy change. If messing with existing settings like this goes against the project's values I'll revert that.Comparison in use:
Before:
before.mp4
After:
after.mp4