Handle resume event and log BFCache pageshow event#2236
Merged
Kuuuube merged 1 commit intoyomidevs:masterfrom Nov 9, 2025
Merged
Handle resume event and log BFCache pageshow event#2236Kuuuube merged 1 commit intoyomidevs:masterfrom
Kuuuube merged 1 commit intoyomidevs:masterfrom
Conversation
CodSpeed Performance ReportMerging #2236 will improve performances by ×2.4Comparing Summary
Benchmarks breakdown
|
jamesmaa
approved these changes
Nov 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #2216 to fix the frozen popup issue
Pages can be set in a "frozen" state. When pages are "resumed", it is very similar to when a page is restored from the BFCache.
To test for a frozen page:
chrome://discards/and whichever page you want to freeze[Freeze]on the page to freezeDo not have any dev tools open (such as console logs) while waiting for the page to freeze. It will prevent the page from freezing.
https://developer.chrome.com/blog/freezing-on-energy-saver
https://developer.chrome.com/docs/web-platform/page-lifecycle-api#event-resume
This does not exist on Firefox. But I have tested that attempting to put a listener on this event in Firefox does not cause any issue.
Also added logging for when this happens as well as the BFCache pageshow event.
resumeandpageshowmay be called together in some cases. Potentially spamming_onDisconnectshould not cause any issues here.