Disconnect cross frame api on BFCache page restore#2216
Merged
Kuuuube merged 1 commit intoyomidevs:masterfrom Oct 21, 2025
Merged
Disconnect cross frame api on BFCache page restore#2216Kuuuube merged 1 commit intoyomidevs:masterfrom
Kuuuube merged 1 commit intoyomidevs:masterfrom
Conversation
djahandarie
approved these changes
Oct 21, 2025
Collaborator
|
Side note, I wonder what happens to my crazy postMessage-based channels in this case... |
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2189
Chrome BFCache changes now break the port connections forcefully and Yomitan ends up unaware of this thinking the connection is just timing out and not disconnected. https://developer.chrome.com/blog/bfcache-extension-messaging-changes
Very similar implementation to the example from the chrome dev blog. Persisted must be checked for to only disconnect when the page is pulled from cache and avoid unnecessary disconnects.
Tested on Firefox as well. Appears to not cause any issues.