Closed
Conversation
Contributor
Author
|
This is the right fix to #84 as your package should never install |
Contributor
Author
|
Do not merge until after #94 is merged. |
Member
|
#94 is merged. Can someone review this? @sigmavirus24 maybe? |
2a2aab4 to
fa6904f
Compare
'config.h' is meant to be a convenience header to be #included at build time, but not installed. Installing it can cause a host of problems for various other projects (for instance, attempting to build u-boot from source while another project's 'config.h' exists in the compiler search path will cause build failures similar to: pepe2k/u-boot_mod#148 Further, I've changed '#include <config.h>' to '#include "config.h"', which should constrain the search path to the current build directories, so if another package with a bugged build has this file installed, it will not cause yaml to miscompile/fail. If you have a file `/usr/include/config.h` on your filesystem, query your package manager to find out what package owns it, and file a bug report against it with your distro maintainers. Signed-off-by: Marty E. Plummer <hanetzer@protonmail.com>
fa6904f to
d90730f
Compare
Contributor
Author
|
@ingydotnet @sigmavirus24 any action on this? |
Member
|
Applied. Pushed. Thanks! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Apr 1, 2019
Changes ======= * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Apr 11, 2019
Fix portlint errors in Makefile Changes in 0.2.2: * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 11, 2019
Fix portlint errors in Makefile Changes in 0.2.2: * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Apr 11, 2019
Fix portlint errors in Makefile Changes in 0.2.2: * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name
kwm81
pushed a commit
to freebsd/freebsd-ports-gnome
that referenced
this pull request
Apr 13, 2019
Fix portlint errors in Makefile Changes in 0.2.2: * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name
swills
pushed a commit
to swills/freebsd-ports
that referenced
this pull request
Apr 14, 2019
Fix portlint errors in Makefile Changes in 0.2.2: * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name git-svn-id: svn+ssh://svn.freebsd.org/ports/head@498674 35697150-7ecd-e111-bb59-0022644237b5
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
May 19, 2019
Changes ======= * yaml/libyaml#95 -- build: do not install config.h * yaml/libyaml#97 -- appveyor.yml: fix Release build * yaml/libyaml#103 -- Remove unused code in yaml_document_delete * yaml/libyaml#104 -- Allow colons in plain scalars inside flow collections * yaml/libyaml#109 -- Fix comparison in tests/run-emitter.c * yaml/libyaml#117 -- Fix typo error * yaml/libyaml#119 -- The closing single quote needs to be indented... * yaml/libyaml#121 -- fix token name typos in comments * yaml/libyaml#122 -- Revert removing of open_ended after top level plain scalar * yaml/libyaml#125 -- Cherry-picks from PR 27 * yaml/libyaml#135 -- Windows/C89 compatibility * yaml/libyaml#136 -- allow override of Windows static lib name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'config.h' is meant to be a convenience header to be #included at build
time, but not installed. Installing it can cause a host of problems for
various other projects (for instance, attempting to build u-boot from
source while another project's 'config.h' exists in the compiler search
path will cause build failures similar to: pepe2k/u-boot_mod#148
Further, I've changed
#include <config.h>to#include "config.h",which should constrain the search path to the current build directories,
so if another package with a bugged build has this file installed, it
will not cause yaml to miscompile/fail.
If you have a file
/usr/include/config.hon your filesystem, queryyour package manager to find out what package owns it, and file a bug
report against it with your distro maintainers.
Signed-off-by: Marty E. Plummer hanetzer@protonmail.com