Skip to content

Rename config.h to yaml_config.h to prevent naming conflicts#84

Closed
biojppm wants to merge 1 commit intoyaml:masterfrom
biojppm:yaml_config_h
Closed

Rename config.h to yaml_config.h to prevent naming conflicts#84
biojppm wants to merge 1 commit intoyaml:masterfrom
biojppm:yaml_config_h

Conversation

@biojppm
Copy link
Copy Markdown

@biojppm biojppm commented Jan 2, 2018

libyaml was installing config.h into $INCLUDE_DIR/config.h (eg /usr/include/config.h), which has a high potential of causing naming conflicts. So I renamed the output file to yaml_config.h. This is working with the cmake build system; automake has not yet been tested.

@ingydotnet ingydotnet mentioned this pull request Jan 7, 2018
@hanetzer
Copy link
Copy Markdown
Contributor

hanetzer commented Jan 9, 2018

ah... therein lies the actual problem. config.h should not be installed, its simply a build-time convenience to have a handy header to #include defining the build target's characteristics. yaml built with autoconf does not install config.h at all. The issue here is with cmake's configuration.

@perlpunk
Copy link
Copy Markdown
Member

We merged #95, so this can be closed, thanks

@perlpunk perlpunk closed this Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants