clp-package: Add Python __future__.annotations import to allow running with Python 3.8.#432
Merged
kirkrodrigues merged 1 commit intoJun 10, 2024
Conversation
junhaoliao
approved these changes
Jun 10, 2024
junhaoliao
left a comment
Member
There was a problem hiding this comment.
Validated on WSL Ubuntu 20.04.6 LTS (Python 3.8.10).
Member
|
I agree with the new PR title to be used as the commit message. |
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
…g with Python 3.8. (y-scope#432)
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
…g with Python 3.8. (y-scope#432)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#416 used syntax that isn't supported by Python 3.8 without the
__future__.annotationsimport. The effect of this is that the search scheduler can't run with Python 3.8 (and all searches will seemingly freeze).This PR adds the import.
Validation performed
sbin/search.shto run a query and ensured that it didn't freeze.