clp-package: Record search job and search task statistics in the database.#416
Merged
Conversation
kirkrodrigues
requested changes
Jun 6, 2024
|
|
||
| async def handle_jobs( | ||
| db_conn_pool, | ||
| database_connection_params: Dict[str, any], |
Member
There was a problem hiding this comment.
How about clp_metadata_db_conn_params? (Same suggestion in other methods.)
| return task_ids | ||
|
|
||
|
|
||
| def set_task_status( |
Member
There was a problem hiding this comment.
Can we deduplicate this with set_job_status?
kirkrodrigues
requested changes
Jun 7, 2024
| the update is conditional on the job's current status matching `prev_status`. If `kwargs` are | ||
| specified, the fields identified by the args are also updated. | ||
| Sets the status of the job or the tasks identified by `job_id` to `status`. If `prev_status` is | ||
| specified,the update is conditional on the job's current status matching `prev_status`. If |
Member
There was a problem hiding this comment.
Suggested change
| specified,the update is conditional on the job's current status matching `prev_status`. If | |
| specified, the update is conditional on the job/task's current status matching `prev_status`. If |
kirkrodrigues
approved these changes
Jun 8, 2024
kirkrodrigues
left a comment
Member
There was a problem hiding this comment.
For the PR title, how about:
clp-package: Record search job and search task statistics in the database.
junhaoliao
pushed a commit
to junhaoliao/clp
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Currently, we store only search jobs in the database, and we don't know how long each task takes to search an archive. This PR introduces search task profiling to provide better insight into the durations.
SearchTaskStatus.Validation performed
sbin/search.sh "org.apache.hadoop.metrics2.impl.MetricsConfig: loaded properties from hadoop-metrics2.properties"and checkedsearch_jobsandsearch_tasksin the database.org*, and waited until it finished. Checkedsearch_jobsandsearch_tasksin the database.search_jobsandsearch_tasksin the database.