Conversation
|
Changes Unknown when pulling 8aab747 on issue-18 into ** on master**. |
3 similar comments
|
Changes Unknown when pulling 8aab747 on issue-18 into ** on master**. |
|
Changes Unknown when pulling 8aab747 on issue-18 into ** on master**. |
|
Changes Unknown when pulling 8aab747 on issue-18 into ** on master**. |
| $file_name = str_replace( \DIRECTORY_SEPARATOR, '/', $file_name ); // Windows compat. | ||
| } | ||
| $plugin_dir = preg_replace( '#(.*plugins[^/]*/[^/]+)(/.*)?#', '$1', $file_name, 1, $count ); | ||
| if ( 0 === $count ) { |
There was a problem hiding this comment.
@lukecarbis Did you mean to remove this too?
There was a problem hiding this comment.
Yes. I don't see the point of forcing the plugin to be inside a plugins or mu-plugins directory. Although I can't imagine a situation where having a plugin elsewhere would actually be the case, enforcing this is simply not required.
I've removed the preg_replace in c48cd3a in favour of double dirname. This makes the assumption that the plugin-base.php file will remain in a child directory of the main plugin. I think that it's okay to make this assumption for now, especially if we will be pursuing the ideas proposed in #12 later on.
|
@lukecarbis I cannot think of a case where the content directory ( |
|
@kopepasah The reason I didn't use |
|
Changes Unknown when pulling c48cd3a on issue-18 into ** on master**. |
|
Note that |
|
Happy to change it if there's a good reason to. Otherwise, any reason why we shouldn't merge? |
westonruter
left a comment
There was a problem hiding this comment.
I'm cool with it if it checks out with @kopepasah.
Resolves #18