Exclude disallowed asset formats from SVN push by frankiejarrett · Pull Request #89 · xwp/wp-dev-lib

frankiejarrett · 2015-04-21T17:46:29Z

Some plugin authors may want to store uncompressed/alternative formats of their graphic assets in the repo. However, WordPress.org only accepts .jpg, .jpeg, .png or .svg asset types. All other asset types (especially large uncompressed files) that serve no purpose should always be excluded from the final plugin package.

Unfortunately .svnignore does not allow negative operators for making ignore exceptions, so the only way I know to accomplish this is to explicitly blacklist certain file extensions, as opposed to whitelisting them like you could with .gitignore:

assets/*
!assets/*.jpg
!assets/*.jpeg
!assets/*.png
!assets/*.svg

In this PR I've created a blacklist of common image formats that may exist in the assets/ directory but should be excluded from the svn-push to WordPress.org.

/cc @westonruter

westonruter · 2015-04-21T23:29:04Z

@fjarrett I don't think this is going to have any effect because svn-push isn't even reading the .svnignore file anymore, right? I think the .svnignore file should be removed, and the logic should be made in the assets rsync command, e.g.:

wp-dev-lib/svn-push

Line 127 in 0695994

rsync -avz --delete $git_tmp_repo_dir/assets/ $svn_tmp_repo_dir/assets/

The rsync command should exclude those types, and include --delete-excluded I think.

Exclude disallowed asset formats from SVN push

…p-tests.sh as workaround for #91 xwp/wp-dev-lib@e81d6a7...d764f5e 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91

…-dev-lib#93 from branch bugfix/wp-tests xwp/wp-dev-lib@9a9effb...7a0e00d f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91 ae5d3c6 Only do JSCS if config file is present 7a0e00d Merge pull request xwp/wp-dev-lib#93 from branch bugfix/wp-tests

…b#93 from branch bugfix/wp-tests xwp/wp-dev-lib@e81d6a7...7a0e00d 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91 ae5d3c6 Only do JSCS if config file is present 7a0e00d Merge pull request xwp/wp-dev-lib#93 from branch bugfix/wp-tests

…b#94 from branch fix/recursive-dir-ignore xwp/wp-dev-lib@e81d6a7...6bc3214 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91 ae5d3c6 Only do JSCS if config file is present 7a0e00d Merge pull request xwp/wp-dev-lib#93 from branch bugfix/wp-tests dd14f8a Fix undefined index for License URI ef30026 Fix symlink creation in readme 2266c69 Match dirs recursively on *.min.js files 6bc3214 Merge pull request xwp/wp-dev-lib#94 from branch fix/recursive-dir-ignore

Blacklist disallowed image file types from SVN push

09cd868

frankiejarrett added the enhancement label Apr 21, 2015

frankiejarrett assigned westonruter Apr 21, 2015

westonruter mentioned this pull request Apr 21, 2015

Adding support for Gitter badges in README markdown #88

Merged

frankiejarrett added 2 commits April 23, 2015 15:06

Remove .svnignore that is no longer used by svn-push

da1c207

Use --include --exclude args for assets rsync

068cf12

frankiejarrett changed the title ~~Blacklist disallowed asset formats from SVN push~~ Exclude disallowed asset formats from SVN push Apr 23, 2015

westonruter added a commit that referenced this pull request Apr 24, 2015

Merge pull request #89 from xwp/feature/exclude-disallowed-asset-types

35909dc

Exclude disallowed asset formats from SVN push

westonruter merged commit 35909dc into master Apr 24, 2015

westonruter deleted the feature/exclude-disallowed-asset-types branch April 24, 2015 00:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Exclude disallowed asset formats from SVN push#89

Exclude disallowed asset formats from SVN push#89
westonruter merged 3 commits intomasterfrom
feature/exclude-disallowed-asset-types

frankiejarrett commented Apr 21, 2015

Uh oh!

westonruter commented Apr 21, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

frankiejarrett commented Apr 21, 2015

Uh oh!

westonruter commented Apr 21, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants