This repository was archived by the owner on Nov 10, 2022. It is now read-only.
Add codeception check to pre-commit hook#85
Merged
westonruter merged 4 commits intomasterfrom Mar 2, 2015
Merged
Conversation
Contributor
|
Looks good! |
pre-commit
Outdated
Contributor
There was a problem hiding this comment.
@shadyvb one thing: should we instead just store codecept.phar in /tmp? If the user doesn't add dev-lib as a submodule with this specific name, then the Codeception test would fail since the path wouldn't exist.
Contributor
Author
There was a problem hiding this comment.
@westonruter Took care of it in b577588, merge at will!
westonruter
added a commit
that referenced
this pull request
Mar 2, 2015
Add codeception check to pre-commit hook
Contributor
|
/five! |
westonruter
added a commit
to xwp/wp-customizer-everywhere
that referenced
this pull request
Mar 3, 2015
…-dev-lib#85 from branch codeception xwp/wp-dev-lib@e4e1607...bc1f881 747693b Update .jshintrc to latest in Core from 2013-11-13 ed561db Bump WP_VERSION to 4.0 in .travis.yml bfcd8cd Update readme.md ea85d57 Remove rsync --delete-excluded af45ca4 Create release tags in SVN f2f616c Merge commit '7a0a6bfa298573afdcce19135062d0353695d207' 709e300 Merge branch 'master' into develop 22ea607 Improve handling of adding entire directories c8b73da Merge commit '084c51c131b2096af565774815e9c83bce9238bb' 9b16437 Remove duplicated tag creation bec7d6a Force-remove tag temporarily 39298f4 Add .svnignore for plugins to use e51fcef Prevent upsearch from going beyond scope of current git repo 995e351 xwpco => xwp 654d71e Update s/bin/dev-lib/ 9589142 Use HTTPS URL instead of SSH URL for submodule 5ed183c Add initial phpunit files for plugins (esp. for VIP) 24af695 Fix path to tests directory 104cac7 Activate all VIP-required plugins for unit tests 65feb8a Merge pull request xwp/wp-dev-lib#48 from branch vip-themes-phpunit e35ce6c Add support for phpunit to run in VIP Quickstart 478bc4d Fix exclude-pattern format and add dev-lib ae95c3f Ignore node_modules from jshintignore b19bdf7 Merge branch 'master' into vip-themes 2ac7bc8 Remove reference to vip-themes branch 4815f59 Merge pull request xwp/wp-dev-lib#39 from branch vip-themes 4d5abcf Improve readability of Bash scripts 06df376 Install PHPUnit phar if PHPUnit is not installed 3bd5840 Prevent YUI_COMPRESSOR_CHECK if no JS files present b6a6438 wp-plugin-dev-lib -> wp-dev-lib 48c6eab Have PHPCS ignore dev-lib by default 2a21e44 Merge pull request #51 from JDGrimes/patch-1 62afbe3 Merge pull request #52 from JDGrimes/patch-2 dd43266 Develop no more 3a59876 Rewrite svn-push to be more robust and to confirm before committing cb7649f Use yoda condition 6286080 Improve discovery of main plugin file 0df8f55 Physically move plugin dir to WordPress install; put symlink at original location f80cc8b Remove -b and echo plugin location 83e3d6e Merge pull request xwp/wp-dev-lib#54 from branch feature/svn-push-rewrite a5e00c0 Merge pull request xwp/wp-dev-lib#50 from branch feature/phpunit-install 2fa80d0 Prevent constructing Travis URLs from non-GitHub remotes a00c15d Merge pull request xwp/wp-dev-lib#59 from branch feature/github-only-travis b758c9e Use absolute paths to exclude paths for rsync 6e15b0b Merge pull request xwp/wp-dev-lib#62 from branch feature/exclude-assets b780832 Account for xargs not doing --no-run-if-empty by default 0e2bdfa Merge pull request xwp/wp-dev-lib#63 from branch feature/xargs-compat b6cc87d Add assets directory 83923d8 Merge pull request xwp/wp-dev-lib#65 from branch feature/add-assets-dir 967afd3 Convert pre[lang] tags into GitHub Markdown codeblocks 9d00483 Prevent too many newlines between bodies daca503 Merge pull request xwp/wp-dev-lib#68 from branch feature/syntax-highlight-readme-md-codeblocks a63b5ec Set SVN mime-type property for images bea1660 Fix path to mime-types.csv 1f52e37 Merge pull request xwp/wp-dev-lib#71 from branch feature/svn-push-mime-types 6af8331 Recognize https: URLs for YouTube, generate HTTPS in readme d0b9eb4 Use https: URL for profiles.wordpress.org links 29000a0 Use https: URL for WPORG tags links d328d44 Merge pull request xwp/wp-dev-lib#73 from branch feature/secure-wporg-urls-in-readme b8f87ba Add support for lock file to cleanup in case of abort/failure 5115011 Exclude phpunit.xml* from SVN a9d7cd6 Use rsync to copy instead of cp, for symlinks 72d90a0 Merge pull request xwp/wp-dev-lib#75 from branch feature/svn-rsync-fixes 88d4646 Fix pre-commit deriving ABSOLUTE_VAGRANT_PATH on vvv a15070a Fix generate-markdown-readme to parse HTTPS GitHub remote URLs 133a4a5 Merge pull request xwp/wp-dev-lib#79 from branch feature/fix-github-https-url-parsing 71c8a0f Merge pull request xwp/wp-dev-lib#74 from branch feature/failure-recovery 2b73706 Make git tag on non-temp repo and push to external remote 0213934 Add filter for code coverage 731287c Add vendor to coverage exclusion d0a5f65 Default to not process uncovered files from whitelist e81d6a7 Exclude tests dir from code coverage e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception
westonruter
added a commit
to xwp/wp-customize-partial-refresh
that referenced
this pull request
Mar 11, 2015
…-dev-lib#84 from branch feature/no-empty-tags xwp/wp-dev-lib@e81d6a7...9a9effb 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags
westonruter
added a commit
to xwp/wp-vip-twig
that referenced
this pull request
Apr 26, 2015
…p-tests.sh as workaround for #91 xwp/wp-dev-lib@e81d6a7...d764f5e 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91
westonruter
added a commit
to xwp/wp-vip-twig
that referenced
this pull request
Apr 26, 2015
…p-tests.sh as workaround for #91 xwp/wp-dev-lib@e81d6a7...d764f5e 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91
westonruter
added a commit
to xwp/wp-widget-favorites
that referenced
this pull request
May 1, 2015
…b#93 from branch bugfix/wp-tests xwp/wp-dev-lib@e81d6a7...7a0e00d 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91 ae5d3c6 Only do JSCS if config file is present 7a0e00d Merge pull request xwp/wp-dev-lib#93 from branch bugfix/wp-tests
westonruter
added a commit
to xwp/wp-widget-favorites
that referenced
this pull request
May 10, 2015
…b#94 from branch fix/recursive-dir-ignore xwp/wp-dev-lib@e81d6a7...6bc3214 2b73706 Make git tag on non-temp repo and push to external remote e724444 Add note about generating code coverage report from PHPUnit dcffd47 Add more info re: PHPUnit Code Coverage db9d4bb Merge master into feature/fix-git-tag-push 9d192ce Merge pull request xwp/wp-dev-lib#80 from branch feature/fix-git-tag-push 44ae78e Prevent empty tags list cbf4001 Add codeception check to pre-commit hook 976aa51 Fix path to codeception phar file 4f7b108 Ignore codeception binary file from git b577588 Store codecept file in /tmp bc1f881 Merge pull request xwp/wp-dev-lib#85 from branch codeception 9a9effb Merge pull request xwp/wp-dev-lib#84 from branch feature/no-empty-tags f3e09c0 Add .jscsrc inheriting from wordpress preset a40029f Re-enable echo-debugged jshint 811f72c Add jscs to Travis script and pre-commit hook c847a87 Add missing .jscsrc file bbd7716 Add jscs excludeFiles to match .jshintignore c5f2447 Add --verbose to jscs d5426d4 Merge pull request xwp/wp-dev-lib#87 from branch feature/jscs 0695994 Fix upsearch not defined errors 6288526 Adding support for Gitter badges in README markdown 09cd868 Blacklist disallowed image file types from SVN push bc2e036 Prevent file_get_contents from being flagged for WordPress-VIP PHPCS standard 4d34c46 Don't change anything in svnignore, it will be removed anyway da1c207 Remove .svnignore that is no longer used by svn-push 5904304 Merge pull request xwp/wp-dev-lib#88 from branch feature/gitter 068cf12 Use --include --exclude args for assets rsync 35909dc Merge pull request xwp/wp-dev-lib#89 from branch feature/exclude-disallowed-asset-types 44ed661 Add double quotes around bash args 02134dd Exclude .ci-env.sh and .jscsrc from svn-push 48cff6d Alphebetize svn-push excludes for my sanity 1a08b58 .gitter is already excluded thanks to .git* e977c36 Merge branch 'master' into exclude-configs-from-svn d236086 Adding mime type declaration for SVG format 0b1f002 Merge pull request xwp/wp-dev-lib#92 from branch svg-mime-type 77c4f03 Merge pull request xwp/wp-dev-lib#90 from branch exclude-configs-from-svn d764f5e Switch to older install-wp-tests.sh as workaround for #91 ae5d3c6 Only do JSCS if config file is present 7a0e00d Merge pull request xwp/wp-dev-lib#93 from branch bugfix/wp-tests dd14f8a Fix undefined index for License URI ef30026 Fix symlink creation in readme 2266c69 Match dirs recursively on *.min.js files 6bc3214 Merge pull request xwp/wp-dev-lib#94 from branch fix/recursive-dir-ignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@westonruter Please review.