Skip to content
This repository was archived by the owner on May 15, 2024. It is now read-only.

[Enhancement] Share Multiple Files#1445

Merged
mattleibow merged 25 commits intoxamarin:mainfrom
dimonovdd:featureShareMultipleFiles
Oct 23, 2020
Merged

[Enhancement] Share Multiple Files#1445
mattleibow merged 25 commits intoxamarin:mainfrom
dimonovdd:featureShareMultipleFiles

Conversation

@dimonovdd
Copy link
Copy Markdown
Contributor

@dimonovdd dimonovdd commented Oct 12, 2020 •
edited
Loading

Description of Change

@andrk0p and I added the ability to send multiple files

Issue Closed

API Changes

Added:

public static Task Share.RequestAsync(ShareMultipleFilesRequest request)
public class ShareMultipleFilesRequest : ShareRequestBase
{
    public IEnumerable<ShareFile> Files { get; set; }
    public static explicit operator ShareMultipleFilesRequest(ShareFileRequest request)
}

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

dimonovdd and others added 11 commits October 8, 2020 22:13
@dimonovdd
Merge branch xamarin:main into dimonovdd:main
7b54620 
Merge branch xamarin:main into dimonovdd:main
@dimonovdd
added "Share Multiple Files" ios
3c3fbfa
@dimonovdd
added "Share Multiple Files" macOS Tizen and Fixed iPad
ff482b4
@dimonovdd
added "Share Multiple Files" UWP
e831686
Merge pull request #1 from dimonovdd/featureShareMultipleFiles
9c5c829 
added "Share Multiple Files" UWP
added "Share Multiple Files" Android
7900025
Merge branch 'featureShareMultipleFiles' of https://github.com/somewv…
05310dc 
…/Essentials into featureShareMultipleFiles
@dimonovdd
Update Share.android.cs
f90cfe0
@dimonovdd
Merge pull request from somewv/featureShareMultipleFiles into dimonov…
ccfd551 
…dd:featureShareMultipleFiles

added "Share Multiple Files" Android
@dimonovdd
fixed small typo "Share Multiple Files"
48c2b6e
Merge pull request #2 from dimonovdd/featureShareMultipleFiles
db360ad 
Feature share multiple files
@dimonovdd
Copy link
Copy Markdown
Contributor Author

dimonovdd commented Oct 12, 2020

@sung-su please check Tizen

mattleibow
mattleibow reviewed Oct 14, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR! Thanks so much. Pity we weren't a bit more forward thinking about the type, but at least we have this much-requested feature.

I have a couple of questions, but that is it.

mattleibow
mattleibow previously approved these changes Oct 14, 2020
View reviewed changes
@mattleibow
Copy link
Copy Markdown
Member

mattleibow commented Oct 14, 2020

Great work! Especially putting up with my weird nitpicks :)

@dimonovdd
Copy link
Copy Markdown
Contributor Author

dimonovdd commented Oct 14, 2020 •
edited
Loading

@mattleibow Wait!
We didn't do documentation

@dimonovdd dimonovdd mentioned this pull request Oct 14, 2020
Merged
@dimonovdd dimonovdd requested a review from mattleibow October 14, 2020 22:39
sung-su
sung-su reviewed Oct 15, 2020
View reviewed changes
@dimonovdd
Copy link
Copy Markdown
Contributor Author

dimonovdd commented Oct 15, 2020

@mattleibow please check docs

mattleibow
mattleibow approved these changes Oct 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested things. All good. Docs great.

Thanks for putting this together!

@mattleibow mattleibow merged commit 043e81e into xamarin:main Oct 23, 2020
dimonovdd added a commit to dimonovdd/Essentials that referenced this pull request Oct 24, 2020
@dimonovdd
Merge branch 'main' into featureContactsGetAll
68623f2 
* main:
  [Enhancement] Share Multiple Files (xamarin#1445)
  [FilePicker] Add support for selecting PDF files (Issue 1404) (xamarin#1412)
  Subset of 1030 pr, easy to review (xamarin#1450)
  Add docs for ContinueUserActivity
  Add ContinueUserActivity impl for Universal App Links
dimonovdd added a commit to dimonovdd/Essentials that referenced this pull request Oct 24, 2020
@dimonovdd
Merge branch 'main' into featureFilePicker
2455bd7 
* main:
  [Enhancement] Share Multiple Files (xamarin#1445)
  [FilePicker] Add support for selecting PDF files (Issue 1404) (xamarin#1412)
  Subset of 1030 pr, easy to review (xamarin#1450)
  Add docs for ContinueUserActivity
  Add ContinueUserActivity impl for Universal App Links
@mattleibow mattleibow mentioned this pull request Nov 6, 2020
Closed
@dimonovdd dimonovdd deleted the featureShareMultipleFiles branch July 12, 2021 20:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sung-su sung-su sung-su left review comments

@mattleibow mattleibow mattleibow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] Sending multiple files to other apps

3 participants

@dimonovdd @mattleibow @sung-su