This repository was archived by the owner on May 15, 2024. It is now read-only.
[FilePicker] Add support for selecting PDF files (Issue 1404)#1412
Merged
mattleibow merged 8 commits intoxamarin:mainfrom Oct 22, 2020
Merged
[FilePicker] Add support for selecting PDF files (Issue 1404)#1412mattleibow merged 8 commits intoxamarin:mainfrom
mattleibow merged 8 commits intoxamarin:mainfrom
Conversation
|
|
mattleibow
reviewed
Oct 4, 2020
Member
mattleibow
left a comment
There was a problem hiding this comment.
Looking really good!
I got a suggestion for docs and also wondering if you could fix the visibility. I think we missed that and it is redundant.
mattleibow
previously approved these changes
Oct 5, 2020
Member
mattleibow
left a comment
There was a problem hiding this comment.
Very nice! Thanks for the PR.
Member
|
/azp run |
dimonovdd
added a commit
to dimonovdd/Essentials
that referenced
this pull request
Oct 24, 2020
* main: [Enhancement] Share Multiple Files (xamarin#1445) [FilePicker] Add support for selecting PDF files (Issue 1404) (xamarin#1412) Subset of 1030 pr, easy to review (xamarin#1450) Add docs for ContinueUserActivity Add ContinueUserActivity impl for Universal App Links
dimonovdd
added a commit
to dimonovdd/Essentials
that referenced
this pull request
Oct 24, 2020
* main: [Enhancement] Share Multiple Files (xamarin#1445) [FilePicker] Add support for selecting PDF files (Issue 1404) (xamarin#1412) Subset of 1030 pr, easy to review (xamarin#1450) Add docs for ContinueUserActivity Add ContinueUserActivity impl for Universal App Links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Add option for picking PDFs on all supported platforms. I realize we could use a FilePickerFileType for all possible filetypes (or maybe a parser), but PDFs is such a common format that i think it justifies the addition.
Bugs Fixed
API Changes
List all API changes here (or just put None), example:
Added:
FilePickerFileType.Pdfenum typeFilePickerFileType.Jpegenum typeBehavioral Changes
None.
PR Checklist
mainat time of PR